This repository was archived by the owner on May 26, 2020. It is now read-only.
Open
Conversation
Collaborator
|
Doesn't this conflict with the yarn.lock? Yarn is a better tool than NPM
(read deterministic) and I'd prefer to stick to it wherever possible.
…On Jun 14, 2017 7:55 PM, "Marc Gagne" ***@***.***> wrote:
Resolves Issue #45 <#45>
- Adds package.lock.json to source control
- Follows other MSFT projects like Roslyn and CoreFX etc.
------------------------------
You can view, comment on, or merge this pull request online at:
#46
Commit Summary
- Adding package lock file
File Changes
- *A* package-lock.json
<https://github.com/EvanBoyle/AzSearch.js/pull/46/files#diff-0> (4564)
Patch Links:
- https://github.com/EvanBoyle/AzSearch.js/pull/46.patch
- https://github.com/EvanBoyle/AzSearch.js/pull/46.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#46>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACb1U3AAiklOa2eC4covMXixIWA2pqXTks5sEB6cgaJpZM4N6OxX>
.
|
Collaborator
|
Unless there is a reason to use npm lock rather than the yarl lock we're already using I think we should close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Issue #45
package.lock.jsonto source control