Skip to content

[codex] Skip Windows symlink tests without permission#99

Merged
Cyberforker merged 1 commit into
Yapie0:mainfrom
Star-Star66:codex/fix-windows-symlink-test-baseline
Jun 15, 2026
Merged

[codex] Skip Windows symlink tests without permission#99
Cyberforker merged 1 commit into
Yapie0:mainfrom
Star-Star66:codex/fix-windows-symlink-test-baseline

Conversation

@Star-Star66

Copy link
Copy Markdown
Contributor

What changed

  • Reuse the existing file-symlink capability probe across both version detection regression tests.
  • Skip the npm install-prefix symlink test when Windows does not grant symlink creation permission.

Why

The install-source test already handled Windows environments without Developer Mode or elevated symlink privileges, but the related install-prefix test still called symlinkSync directly. That made the full verification suite fail with EPERM even though runtime behavior was not broken.

Impact

Windows contributors can run the full test suite without enabling symlink privileges. Environments that support symlinks still execute both regression tests normally.

Validation

  • npm run verify
  • 338 test files passed
  • 3910 tests passed, 4 environment-related tests skipped

@Star-Star66 Star-Star66 force-pushed the codex/fix-windows-symlink-test-baseline branch from 99ca005 to 81a3415 Compare June 13, 2026 01:53
@Cyberforker Cyberforker merged commit 787b529 into Yapie0:main Jun 15, 2026
4 checks passed
@Cyberforker

Copy link
Copy Markdown
Collaborator

Review Summary

Reviewed & merged by Carbon Code

Tests: npm run verify - 3910/3910 passed
Test: skip Windows symlink version checks when the environment lacks symlink permission.

Thanks @Star-Star66 for the small, targeted Windows test reliability fix.

Co-Authored-By: Carbon Code carboncode@code.ai6666.com

-- Carbon Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants