feat(notifications): add first-class provider settings - #3622
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Exact-head verification note for — |
|
Exact-head hold for — |
|
Renewed current-dev hold: after public-sync repair #3630 merged, — |
|
Successor exact head: |
|
Canonical hostile exact-head review verdict\n\n- Exact head: |
|
Corrected exact-head hostile review\n\n- Exact head: |
|
Exact-head hostile review for PR #3622 Review boundary
Terminal verdict: MERGE_READY Evidence
Material review conclusions
Expanded-suite classification Automated/comment classification
Review signature: — |
The SDK package smoke installed the workspace agent-core resolution, so packaged coding-agent imports could bind to an older registry/source package missing a named export. Pack and override the matching tarball, then assert installed identity before probing the SDK surface. Lore-id: issue-3570-package-smoke\nConstraint: do not expose internal terminal ownership metadata as public API\nConstraint: preserve existing notification/provider contracts\nRejected: blind root export | expands internal ownership metadata into public API\nTested: bridge-client SDK package smoke; focused notification/provider/session/host wiring tests; package typechecks; coding-agent build\nConfidence: high\nScope-risk: narrow\nReversibility: easy\nDirective: retain black-box packed-install coverage
The previous realpath assertion compared an installed path with itself and could not reject fallback content. Compare the installed package against the temporary packed install and extracted tarball bytes so same-version registry or workspace resolution cannot mask the package boundary. Lore-id: issue-3570-package-smoke-provenance\nConstraint: no blind export of internal terminal ownership metadata\nRejected: tautological realpath check | does not prove packed provenance\nTested: bridge-client SDK package smoke; coding-agent typecheck\nConfidence: high\nScope-risk: narrow\nReversibility: easy
Regenerate the public docs index and daemon generation manifest after reconciling PR #3622 with the current dev lifecycle tree. This keeps the resolved provider-settings surface and generated authority digests byte-synchronized. Confidence: high Scope-risk: narrow Reversibility: clean-revert Tested: focused notification suite 849/849; notification red-team/e2e suite 44/44; generation/schema tests 48/48; package smoke root 657/sdk 48 Not-tested: independent hostile review on the new exact head
cf24023 to
4ed9aa6
Compare
|
PR #3622 exact-head rebase reconciliation Rebased and pushed the actual PR head branch
Conflict resolution scope
Latest exact-head validations
Review-gate evidence The review evidence contract was repaired after these exact receipt findings:
The rerun then reached this exact remaining gate finding:
This is a conservative Ultragoal runtime computer-suite requirement triggered by the changed settings-schema path, not a source defect identified by the rebase or notification validations. No unrelated computer-suite investigation was performed, and the finding is not being suppressed. Fresh hostile review Required: yes. The prior hostile review was bound to Review signature: — |
The rebased provider-settings guard expands the protected chat configuration and endpoint inventory, so current dev v34 correctly rejects the unchanged contract version. Bump the policy contract to v35 and regenerate the manifest without changing daemon generations. Root-cause: guard policy changed relative to origin/dev but GUARD_CONTRACT_VERSION remained 34. Constraint: preserve Telegram generation 40 and Discord/Slack generation authority. Tested: current-tree manifest validation and generation guard test suite. Confidence: high Scope-risk: narrow Reversibility: clean-revert
Current dev already protects generation 40, Discord 23, and Slack 22. The provider-settings changes alter those protected lifecycle declarations, so the rebased branch must advance each family and the guard policy contract before CI can accept the manifest. Root-cause: CI correctly rejected an unchanged guard contract and then detected protected lifecycle changes without strictly higher family generations. Constraint: preserve current-dev lifecycle authority while fencing provider-settings admission. Tested: generation guard 556/556 tests; current-tree manifest validation. Confidence: high Scope-risk: narrow Reversibility: clean-revert
|
PR #3622 exact-head generation-guard repair Repaired and pushed the actual PR branch after CI rejected head
Root cause from the failed Telegram daemon generation-guard job
Minimal repair
Local repair evidence
The prior guard failure was a real generation-contract defect in the rebased branch, not an infrastructure failure. Fresh exact-head review remains required for Repair signature: — |
|
CI follow-up for PR #3622 The Telegram daemon generation guard now passes on exact head
The remaining Dev CI workflow shards are still queued/in progress; this update claims only the repaired guard, not full workflow completion. The PR remains open and unmerged. Repair signature: — |
|
PR #3622 CI status update for repaired head The Telegram daemon generation guard is green on the repaired head (
The PR remains open and unmerged. This comment records the exact CI blocker rather than suppressing it. Repair signature: — |
Apply the repository formatter to the packed SDK smoke script so the required check:tools gate matches the committed source. No runtime behavior changes. Root-cause: CI Biome check rejected formatting in the tar extraction and installed-package identity conditionals. Constraint: formatting-only change; do not alter packed SDK behavior. Tested: bun run check:tools; generation guard v35; Telegram generation tests. Confidence: high Scope-risk: narrow Reversibility: clean-revert
|
PR #3622 CI formatter repair Applied the requested formatting-only correction and pushed a fresh exact head.
Repair scope
Validation
The push triggered a fresh CI run for the new head. No merge was performed. Repair signature: — |
|
MERGE_READY — fresh hostile exact-head review for |
|
POST-MERGE DOGFOOD COMPLETE\n\n- PR #3622 verified merged through GitHub REST at dev commit |
|
Signed: Yeachan-Heo / fresh-session batch lane OWNER LANE RETIRED — terminal evidence reconciled.
|
Closes #3570
Summary
Verification
bun run check:tspassedbun run check:rspassed91254dc64d2207bc7d8827482dec4e09f82e6a03d93d602816bddc3e4b3245e8