Skip to content

test(perf): anchor provenance expectations to checkout - #3659

Merged
Yeachan-Heo merged 1 commit into
devfrom
fix/dev-ci-71e9-perf-provenance
Jul 31, 2026
Merged

test(perf): anchor provenance expectations to checkout#3659
Yeachan-Heo merged 1 commit into
devfrom
fix/dev-ci-71e9-perf-provenance

Conversation

@Yeachan-Heo

Copy link
Copy Markdown
Owner

Summary

  • anchor both perf provenance expectations to the benchmark checkout
  • preserve the runner contract: checked-out HEAD and benchmark checkout cwd take precedence over GITHUB_SHA and caller cwd
  • avoid changing runner source because the source already derives its repository root from import.meta.dir

Verification

  • focused provenance tests: 2 pass, repeated twice
  • full packages/coding-agent/test/perf-corpus.test.ts: 45 pass
  • bun --cwd=packages/coding-agent run check: pass
  • native build: pass
  • focused tests from a temporary caller cwd: 2 pass

Failure run: 30630819543
Failure commit: 71e9c95

No workflow reruns or cancellations were performed.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

GJC receipt

Repaired the exact post-merge perf provenance failures from run 30630819543 at dev 71e9c95d9abdd9a96d223f815f6be29d47617e76.

Root cause: both tests computed their expected Git HEAD with git rev-parse HEAD using the CI caller cwd. The runner itself already resolves the benchmark checkout as path.resolve(import.meta.dir, "../../.."), so the source contract was correct; the test setup was stale for CI shard execution outside the checkout.

Change: 2ee717e12 anchors test expectations to that checkout root. No NotificationServer, BashTool, session/broker/ACP, Telegram, or settings repaint files were touched.

Evidence:

  • focused tests: 2 pass, repeated twice
  • full perf corpus suite: 45 pass / 0 fail
  • focused suite from a temporary caller cwd: 2 pass
  • bun --cwd=packages/coding-agent run check: pass
  • native build: pass
  • no workflow reruns or cancellations


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo
Yeachan-Heo force-pushed the fix/dev-ci-71e9-perf-provenance branch from 2ee717e to 359d318 Compare July 31, 2026 13:15
@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

Rebase receipt

Rebased the single test-only fix onto current immutable dev base 80825a68347201ac6457395f963a9e5bc06d38af.

  • successor commit: 359d3181a
  • old commit: 2ee717e12
  • merge-base: 80825a683
  • diff remains limited to packages/coding-agent/test/perf-corpus.test.ts
  • benchmark runner source and provenance contract unchanged
  • focused provenance tests after rebase: 2/2 passed
  • force-pushed with --force-with-lease

Fresh exact CI is required for this successor. The stale workflow was not rerun or cancelled.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

Inherited hold receipt — exact successor 359d3181a

The implementation is complete and the successor remains exactly test-only (packages/coding-agent/test/perf-corpus.test.ts). Product verification is green, including focused provenance tests and affected package checks.

Merge is disabled solely by inherited current-dev Telegram generation authority drift: the generation guard reports native authority digests do not byte-match the current tree. This is current-tree authority drift owned by Telegram repair PR #3661, not by the perf provenance diff. No Telegram/native manifest/source/workflow changes were made in #3659.

Route: blocked-preserve / route-follow-up. Preserve worktree and branch unchanged; after #3661 merges, rebase once onto current dev, retain the single test-only commit, and obtain fresh exact CI. Old workflow rerun/cancel is forbidden.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

Current-dev route update: preserve #3659 ownership

Run 30655615693 at exact dev 699a634 leaves the two shard-5 perf provenance tests as the actionable root; evidence producer and aggregate failures are downstream. The old #3659 Telegram hold is resolved by #3679/#3681, so the implementation remains owned by this PR/subsystem, not by Telegram.

The current PR head 359d3181a61a7136a096288f922205c14cde63ff is stale against current dev and must not merge. A contributor-created current-dev successor is required, with the same test-only scope, focused provenance tests, exact terminal CI, and hostile review. No mutation owner is created now: route this successor only after one existing owner retires. No contributor branch mutation or workflow rerun was performed.


[repo owner's gaebal-gajae (clawdbot) 🦞]

The provenance runner already resolves Git HEAD from the benchmark checkout, but these expectations resolved HEAD from the caller cwd. CI invokes the shard outside the repository, so both contract tests failed before exercising the runner.\n\nLore-id: 30630819543\nConstraint: benchmark checkout HEAD and cwd must dominate workflow SHA and caller cwd\nRejected: changing runner provenance | current source already uses import.meta.dir-derived checkout root\nConfidence: high\nScope-risk: narrow\nReversibility: easy\nTested: focused provenance tests twice; full perf corpus test; coding-agent check; native build\nNot-tested: workflow rerun (explicitly prohibited)
@Yeachan-Heo
Yeachan-Heo force-pushed the fix/dev-ci-71e9-perf-provenance branch from 359d318 to 5cce992 Compare July 31, 2026 20:01
@Yeachan-Heo
Yeachan-Heo merged commit a9189f6 into dev Jul 31, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant