fix(coding-agent): repair merged dev CI shard failures - #3721
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c762b93597
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let chunk_len = chunk.len(); | ||
| match bounded_tx.try_send(chunk) { |
There was a problem hiding this comment.
Flush pending loss markers before EOF
When the callback queue overflows and the command is subsequently aborted or times out, dropped_chunks is now reported only after rx closes. The Bash executor stops accepting callbacks as soon as abort/timeout wins (packages/coding-agent/src/exec/bash-executor.ts:382-384), so this final marker is discarded and the returned output silently omits chunks. Flush a pending marker once callback capacity becomes available without consuming the slot needed by the next retained chunk, rather than waiting exclusively for stream termination.
Useful? React with 👍 / 👎.
|
VERDICT: MERGE_READY Fresh hostile read-only review of exact head c762b93 against base a8757cb. Evidence:
No merge performed by this review. — |
Summary
Repairs the two confirmed post-merge dev-CI failures tracked by #3720. This is independent of merged PR #3694 and does not rewrite its history.
TAIL.Verification
bun test packages/coding-agent/test/telegram-baseline-manifest.test.ts— 17 passed, 0 failedbun test packages/coding-agent/test/tools.test.ts --test-name-pattern 'should bound async and monitor output while preserving full local evidence'— 1 passed, 0 failed\n-bun test packages/coding-agent/test/sdk-adapter-dispositions.test.ts— 576 passed, 0 failed\n-bun packages/coding-agent/scripts/generate-sdk-adapter-parity-manifest.ts --check— passed\n-bun packages/coding-agent/scripts/generate-sdk-operation-inventory.ts --check— passed\n-cargo test -p pi-natives shell::tests— 8 passed, 1 flaky existing failure; isolated rerun ofembedded_external_command_runs_in_its_own_sessionpassed\n-git diff --check— passed\n\nIssue: coding-agent dev-CI batch repair: shard-3 manifest parity count and shard-5 async shell output truncation #3720\n\nNo release, tag, or merge performed.