Skip to content

fix(coding-agent): repair merged dev CI shard failures - #3721

Merged
Yeachan-Heo merged 1 commit into
devfrom
repair/pr-3694-adapter-parity-count
Aug 1, 2026
Merged

fix(coding-agent): repair merged dev CI shard failures#3721
Yeachan-Heo merged 1 commit into
devfrom
repair/pr-3694-adapter-parity-count

Conversation

@Yeachan-Heo

Copy link
Copy Markdown
Owner

Summary

Repairs the two confirmed post-merge dev-CI failures tracked by #3720. This is independent of merged PR #3694 and does not rewrite its history.

  • Update the Telegram baseline manifest receipt assertion from 570/95-per-adapter to the generated Q29 parity total of 576/96-per-adapter.
  • Defer native shell loss-marker delivery until retained chunks have drained, so callback-boundary loss markers cannot split terminal async output evidence such as TAIL.

Verification

  • bun test packages/coding-agent/test/telegram-baseline-manifest.test.ts — 17 passed, 0 failed
  • bun test packages/coding-agent/test/tools.test.ts --test-name-pattern 'should bound async and monitor output while preserving full local evidence' — 1 passed, 0 failed\n- bun test packages/coding-agent/test/sdk-adapter-dispositions.test.ts — 576 passed, 0 failed\n- bun packages/coding-agent/scripts/generate-sdk-adapter-parity-manifest.ts --check — passed\n- bun packages/coding-agent/scripts/generate-sdk-operation-inventory.ts --check — passed\n- cargo test -p pi-natives shell::tests — 8 passed, 1 flaky existing failure; isolated rerun of embedded_external_command_runs_in_its_own_session passed\n- git diff --check — passed\n\nIssue: coding-agent dev-CI batch repair: shard-3 manifest parity count and shard-5 async shell output truncation #3720\n\nNo release, tag, or merge performed.

Q29 added six adapter parity rows without updating the baseline receipt count, and native shell callback loss markers could split retained async tail evidence. Keep the repair independent from merged PR #3694.

Fixes #3720

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c762b93597

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 297 to 298
let chunk_len = chunk.len();
match bounded_tx.try_send(chunk) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Flush pending loss markers before EOF

When the callback queue overflows and the command is subsequently aborted or times out, dropped_chunks is now reported only after rx closes. The Bash executor stops accepting callbacks as soon as abort/timeout wins (packages/coding-agent/src/exec/bash-executor.ts:382-384), so this final marker is discarded and the returned output silently omits chunks. Flush a pending marker once callback capacity becomes available without consuming the slot needed by the next retained chunk, rather than waiting exclusively for stream termination.

Useful? React with 👍 / 👎.

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

VERDICT: MERGE_READY

Fresh hostile read-only review of exact head c762b93 against base a8757cb.

Evidence:

  • Narrow two-file diff only: crates/pi-natives/src/shell.rs and packages/coding-agent/test/telegram-baseline-manifest.test.ts.
  • Shard-3 repair is coherent with the generated adapter-parity manifest: Q29 contributes six rows, changing the aggregate to 576 total / 96 per adapter; generator parity coverage remains unchanged and the baseline receipt assertion now matches it.
  • Shard-5 repair defers the shell loss marker until retained callback chunks drain, preventing the marker from splitting terminal async output while preserving truncation observability.
  • Exact regression tests passed: 17/17 baseline-manifest tests and 1/1 async shell output regression.
  • Adapter-disposition suite passed: 576/576.
  • Adapter parity and SDK operation inventory generator checks passed; git diff --check passed.
  • PR CI is terminal green: 17 successful checks, 6 skipped, 0 non-success conclusions.
  • No unrelated scope drift found.

No merge performed by this review.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

VERDICT: MERGE_READY

Technical review is complete at exact head c762b93 against base a8757cb. CI is green and no blockers remain. No merge performed.


[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo
Yeachan-Heo merged commit 280ce5f into dev Aug 1, 2026
23 checks passed
@Yeachan-Heo
Yeachan-Heo deleted the repair/pr-3694-adapter-parity-count branch August 1, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant