Skip to content

Use ReadTimeout as base timeout exception for the requests client#337

Merged
sjaensch merged 1 commit into
Yelp:masterfrom
sjaensch:use-requests-readtimeout
Dec 7, 2017
Merged

Use ReadTimeout as base timeout exception for the requests client#337
sjaensch merged 1 commit into
Yelp:masterfrom
sjaensch:use-requests-readtimeout

Conversation

@sjaensch
Copy link
Copy Markdown
Contributor

@sjaensch sjaensch commented Dec 7, 2017

This fixes issues with code that catches requests.exceptions.ReadTimeout, which we broke by using requests.exceptions.Timeout as base class.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 7, 2017

Coverage Status

Coverage increased (+0.003%) to 98.582% when pulling 95f28d3 on sjaensch:use-requests-readtimeout into c524bce on Yelp:master.

@sjaensch sjaensch merged commit fbf429d into Yelp:master Dec 7, 2017
@sjaensch sjaensch deleted the use-requests-readtimeout branch December 7, 2017 12:22
@ngaya-ll
Copy link
Copy Markdown
Contributor

What about requests.exceptions.ConnectTimeout?

@macisamuele
Copy link
Copy Markdown
Collaborator

@ngaya-ll : connection errors are not integrated yet because we didn't find a reliable way of testing those type of errors with fido client; but definitely our plan is to "generalize" also those type of errors (#346)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants