Deprecate use_msgpack in favor of Accept header#504
Open
ltrottier-yelp wants to merge 2 commits into
Open
Conversation
The use_msgpack request option is now redundant since clients can set the Accept header directly via _request_options or default_request_options. Emit a DeprecationWarning guiding users to the standard header approach. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ymilki
requested changes
May 11, 2026
Co-authored-by: milki <milki@yelp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Part of a multi-repo change to support msgpack content negotiation via standard HTTP headers:
use_msgpack only ever set Accept: application/msgpack. With the new standard header approach, users can set both Content-Type and Accept directly, making use_msgpack redundant.
Test plan