API for adding java-based spouts to Pyleus topologies#99
API for adding java-based spouts to Pyleus topologies#99mzbyszynski wants to merge 7 commits intoYelpArchive:developfrom
Conversation
|
@mzbyszynski, sorry for the late answer. This is a feature that I believe would be a very good addition to pyleus and it is a fair amount of work, so thank you for doing that. And thank you for writing documentation as well :) (Since it also closes #93, I guess this is based on #94, right?) However, since this is such a huge change, also in terms of "user interface", I believe we should have people thoughts on that (pinging @patricklucas and @ecanzonieri here) before actually starting to discuss about the details of the code.
Coming to the first and most important question of the list, personally, I have mixed feelings about this change. |
|
I'm looking into using pyleus (love it a ton so far), but we are using kinesis instead of kafka, and AWS has a supported kinesis spout for storm that I'd really like to use. This feature would be really awesome for my use case. Looking through the changes and documentation it looks pretty straight forward to use this. I'm gonna give it a try for my use case and report back. |
Adds the ability to integrate java-based spouts with Pyleus topologies, based on the way that the kafka spout was previously integrated into Pyleus.
In a nutshell, to add a java spout to your topology you need to:
SpoutProviderinterface and package it in a jar.SpoutProviderclass mapping to yourpyleus.conftype,output_fieldsandoptions.Documentation
Testing:
pyleus localwith Storm 0.9.3.pyleus submitwith Storm 0.9.3.pyleus submitwith Storm 0.9.3 and Kafka 0.8.2.All questions, feedback and code review comments welcome! I was thinking about adding a readme.md file to the java_spout_provider example, since there are a bunch of steps to build it, but I didn't see anything similar in the other examples so I didn't want to violate any project conventions. Some guidance on that would be great as well.
Thanks!
Closes #93
Closes #91