chore(deps): ignore TypeScript major bumps + drop unused pbf direct dep - #4228
Merged
Conversation
Dependabot: ignore TypeScript major-version updates (TS7's native compiler drops the JS compiler API @typescript-eslint needs, breaking lint:ci). Remove the unused top-level `pbf` and `@types/pbf` deps; the real consumers are transitive under maplibre-gl and keep their nested pbf@4.x. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018e4dtLyWeYJYJ7SbgFvGG1
|
Claude finished @Yeraze's task —— View job PR Review: chore(deps): ignore TypeScript major bumps + drop unused pbf direct dep
Review SummaryThis is a clean dependency-hygiene PR. Both changes are well-reasoned and correctly implemented. 1. Dependabot: Ignore TypeScript major bumps (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small dependency-hygiene changes.
1. Dependabot: ignore TypeScript major-version bumps
Adds an
ignoreentry to the root npm ecosystem block so Dependabot stopsproposing TypeScript major updates.
Why: TypeScript 7 ships a native (Go) compiler package that drops the
JS compiler API
@typescript-eslintdepends on. A TS7 major bump breakslint:citoday even though our own code is already TS7-clean. This followsthe hold on Dependabot PR #4086 and the review discussion in #4091 — we
hold major bumps until the tooling ecosystem ships TS7-native support.
Minor/patch TS updates are unaffected.
2. Remove unused
pbf/@types/pbfdirect dependenciesNothing in
src/ordesktop/imports thepbfmodule — the only.pbfreferences are the vector-tile file-extension string, which is unrelated.
The real consumers are transitive under
maplibre-gl(
@mapbox/vector-tile,@maplibre/vt-pbf,maplibre-gl), which pin theirown nested
pbf@4.xand are unaffected.Removing the top-level dep only drops the (unused) dedup entry. Verified the
regenerated
package-lock.jsonstill contains nestedpbf@4.0.2under themaplibre tree, so vector-tile decoding is intact. (Notably the old top-level
pbf@5.1.2wasn't even satisfying maplibre's4.xrequirement, confirmingit was dead weight.)
Verification
npm run typecheck— cleannpm run build— succeedsBaseMap + VectorTileLayer included)
🤖 Generated with Claude Code