Enhance SMILES decoding and inference capabilities#28
Open
T4ras123 wants to merge 1 commit into
Open
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a flexible and extensible decoding framework for molecular conformer generation, allowing support for multiple serialization schemes (cartesian, cartesian_binned, uniform, quantile) and configuration via CLI or config files. It refactors the decoding logic in both single and multi-conformer inference pipelines, introduces a new
BinConfigdataclass for bin configuration, and expands test set and CLI options.Key changes:
Decoding Framework & Logic
decode_conformer_by_serializationfunction insmiles_encoder_decoder.pyto handle decoding for various serialization schemes, including new support for "uniform" and "quantile" binning using configuration files. (decode_conformer_by_serialization,BinConfig,decode_cartesian_with_config) [1] [2]normalize_serialization_tagto standardize and validate serialization mode input.Configuration and CLI Improvements
serialization_tag) and paths to uniform/quantile bin configuration files, both for single and multi-conformer inference. [1] [2] [3] [4] [5]binnedandserialization_tagto ensure consistent decoding. [1] [2]Test Set Handling
Utility and Robustness
strip_smilesto remove[SERIALIZATION]...[/SERIALIZATION]tags for cleaner input.These changes make the codebase more modular, easier to extend with new serialization schemes, and more user-friendly for both research and production settings.