Fix false aborts on ordinary Codex requests - #5
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Allows ordinary Codex requests with unmatched reconstructed history to pass through while preserving fail-closed transition and checkpoint behavior.
Changes:
- Waits for active transitions and validates replay state.
- Adds regression tests for request pass-through and transition handling.
- Bumps the package version and updates copyright ownership.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
session-coordinator.ts |
Refines request replay and transition coordination. |
session-coordinator.test.ts |
Adds regression coverage for new behavior. |
package.json |
Bumps version to 0.0.2. |
LICENSE |
Updates the copyright holder. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
YeungKC
force-pushed
the
hotfix/0.0.2-request-pass-through
branch
from
August 16, 2026 13:56
068b46a to
1f3caed
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
session-coordinator.ts:233
- A model selection can occur while this promise is pending. The completing transition then unconditionally deletes
pendingBySession, so the recursive request loses the newer transition and reachesrecoverCurrentModel, which creates its checkpoint withbasePayloadset toundefined. Request-specific fields such as reasoning effort or text verbosity are therefore dropped for the newer model. Preserve/version the pending transition and only delete the transition that actually completed, so the recursive call takes the pending path and forwards this request'sbasePayload.
const activeTransition = transitionBySession.get(sessionId);
if (activeTransition) {
await activeTransition;
return prepareRequest(model, ctx, requestInput, basePayload);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.0.2Verification
bun test— 43 pass