Merges the feature branch into trunk#23424
Merged
Merged
Conversation
Verifies the Search and Social field sets, their labels, the field key/label mappings, and that each call returns a fresh object. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ntions Sources the field set ids from the central constants, removes the PropTypes per the React 19 convention, and sizes the loading skeleton to the new shared PAGE_SIZE so the loading state matches a full page. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replaces the tab panel placeholders with the field-set data table, deriving the tabs from the field sets so both share one source. The rows come from a temporary 20-row fixture matching the design's page size until the list endpoint (Free-BE) feeds the provider. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add PSR-3 logging to the bulk update flow following the myyoast-client pattern: classes implement LoggerAwareInterface and default to a NullLogger, with the real Logger auto-injected by Logger_Aware_Pass. Bulk_Updater now logs a warning with the post id and exception message when a meta write throws, which was previously swallowed silently behind the SAVE_FAILED result. The route logs the incoming batch and each validation rejection at debug level to aid request debugging. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Jordi-PV <88150345+JorPV@users.noreply.github.com>
Co-authored-by: Jordi-PV <88150345+JorPV@users.noreply.github.com>
The getters return an empty string (not undefined) for unknown ids, which silently defeats ?? fallbacks; spell that out in the JSDoc. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Aligns the new bulk edit Tools page with the existing legacy bulk editor, which is gated at the menu level by wpseo_manage_options. The previously used wpseo_bulk_edit capability is registered but dormant and gates nothing elsewhere; per-post authorization is still handled separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The collector now skips post types with show_ui === false, but the test fixtures had no show_ui property, causing an undefined-property error. Adds show_ui to the fixtures and a case asserting UI-less types are skipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…m:Yoast/wordpress-seo into bulk-editor/page-title-search-social-tabs
…m:Yoast/wordpress-seo into bulk-editor/page-title-search-social-tabs
…tegration feat(bulk-editor): scaffold bulk edit page and React provider seam
…ditor/page-title-search-social-tabs
…itor/content-type-sub-navigation
…cial-tabs' into bulk-editor/page-title-search-social-tabs
…itor/content-type-sub-navigation
…or/field-set-data-table-render-sorting
…cial-tabs Add Bulk editor page header and Search/Social appearance tabs
- Move the select-all checkbox out of the column header row into the multi-select toolbar row, where Free-FE 9 adds the Select menu and Free-FE 7 the Filters button. - Name the row-checkbox column for assistive tech only; the design shows no visible header for it. - Render the content status as plain muted text instead of a badge, limited to the design's status vocabulary (draft, pending, future). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Match the Support/Settings page construction: responsive page padding, the navigation in an aside, the content column growing up to max-w-page (instead of capping the layout at max-w-7xl), and the card as the main landmark. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…or/field-set-data-table-render-sorting
…ditor/field-set-data-table-render-sorting
feat(bulk-editor): expose unsaved-edits state to the bulk-actions slot
…-suggested-pending-changes-alert feat(bulk-editor): add pending-changes guard seam for external plugins
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…into bulk-editor/add-learnmore-link
…dpress-seo into bulk-editor/add-learnmore-link
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add learn more link to the bulk editor AI upsell modal
thijsoo
added
the
changelog: enhancement
Coverage Report for CI Build 815133Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+1.4%) to 55.017%Details
Uncovered Changes
Coverage Regressions78 previously-covered lines in 7 files lost coverage.
Coverage Stats
💛 - Coveralls |
Update the bulk AI upsell body text to mention products, posts and pages, and expose the UpsellModal and useAiUpsell on window.yoast.bulkEditor so Premium can reuse the same modal for its WooCommerce SEO subscription upsell instead of duplicating it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move the upsell body copy into useAiUpsell so the product-specific text
("products, posts, pages and more") is shown only for the product content
type, while all other content types keep the original generic copy.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ange Previously only a status-filter change reset the row selection. A search change or content-type switch also changes which rows are shown, so a bulk action could still act on rows the user can no longer see. Consolidate all three resets in the selection slice and drop the separate content-type reset effect from the content component. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rename the per-cell slot fill prop onApplied to onFieldApplied to match its sibling props onSaveField and onDiscardField, and expose the underlying editing setter under the same on-handler name for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…inline-feedback # Conflicts: # packages/js/src/bulk-editor/components/bulk-editor-content.js
The non-product upsell body copy was duplicated in the useAiUpsell hook and as the UpsellModal default description. Move it to a single AI_UPSELL_DESCRIPTION constant so both reference one source of truth. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(bulk-editor): clear selection on filter change and expose onApplied slot prop
…-modal feat(bulk-editor): update AI upsell copy and expose modal for Premium
style(bulk-editor): add page styles for Premium AI error notices
JorPV
added
the
innovation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces or edits images or SVGs.Innovation
innovationlabel.Fixes #