Skip to content

feat(bulk-editor): add "needs improvement" filter options to the filters dropdown#23438

Draft
FAMarfuaty wants to merge 1 commit into
trunkfrom
1346-bulk-editor-add-needs-improvement-filter-option-to-filter-dropdown
Draft

feat(bulk-editor): add "needs improvement" filter options to the filters dropdown#23438
FAMarfuaty wants to merge 1 commit into
trunkfrom
1346-bulk-editor-add-needs-improvement-filter-option-to-filter-dropdown

Conversation

@FAMarfuaty

Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and committed the results, if my PR introduces or edits images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 0

Warning

No base build found for commit 0a4c801 on trunk.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 45.864%

Details

  • Patch coverage: 22 uncovered changes across 2 files (55 of 77 lines covered, 71.43%).

Uncovered Changes

File Changed Covered %
src/bulk-editor/infrastructure/posts/post-meta-posts-collector.php 21 0 0.0%
src/bulk-editor/infrastructure/posts/indexable-posts-collector.php 14 13 92.86%
Total (8 files) 77 55 71.43%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 61506
Covered Lines: 29582
Line Coverage: 48.1%
Relevant Branches: 11978
Covered Branches: 4121
Branch Coverage: 34.4%
Branches in Coverage %: Yes
Coverage Strength: 7.22 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants