Skip to content

Integrate with new YouClap shared lib#4

Open
portellaa wants to merge 1 commit into
masterfrom
feat/integrate_with_shared_lib
Open

Integrate with new YouClap shared lib#4
portellaa wants to merge 1 commit into
masterfrom
feat/integrate_with_shared_lib

Conversation

@portellaa

Copy link
Copy Markdown
Member

No description provided.

@tallnato tallnato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

Comment thread Package.swift Outdated
.package(url: "https://github.com/vapor/vapor.git", from: "3.3.0"),
.package(url: "https://github.com/vapor/fluent-mysql.git", from: "3.0.1"),
.package(url: "https://github.com/ReactiveCocoa/ReactiveSwift.git", from: "6.0.0")
.package(url: "https://github.com/youclap/vapor-shared.git", .branch("master"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should do releases, instead of using directly master?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap

@portellaa
portellaa force-pushed the feat/integrate_with_shared_lib branch from f0e5316 to 2865da8 Compare August 28, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants