feat: make hover tooltips accessible on touch devices#73
Open
sheikhwasimuddin wants to merge 1 commit into
Open
feat: make hover tooltips accessible on touch devices#73sheikhwasimuddin wants to merge 1 commit into
sheikhwasimuddin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes tooltip-based information (like Distribution, Playstyle badges, and Language tier) accessible on mobile devices by adding touch support, while preserving the existing pure-CSS hover behavior for desktop users.
Changes
Tipcomponent (ScoutReport.tsx) to maintain anisOpenstate for touch/click events.Escapekey to cleanly dismiss the tooltip.tabIndex={0}and a subtle focus ring (focus-visible:ring-2).group-hover/tip:blockclass so desktop hover behavior remains untouched.How to test
Tabkey to focus a tooltip, and pressEnterorSpaceto toggle it.Before
After