fix(pwa): skip private network hosts in SW to restore Chrome PNA prompt#6
Merged
Conversation
The generateSW-mode Service Worker was intercepting fetch requests to private/local IPs (e.g. 192.168.x.x), which prevented Chrome from showing its Private Network Access permission dialog. Switch to injectManifest with a custom SW that imports isPrivateOrLocalHost (ipaddr.js) to let those requests fall through to the page context. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generateSW-mode Service Worker was intercepting fetch requests to private/local IPs (e.g. 192.168.x.x), which prevented Chrome from showing its Private Network Access permission dialog. Switch to injectManifest with a custom SW that imports isPrivateOrLocalHost (ipaddr.js) to let those requests fall through to the page context.