refactor: reader settings - #48
Merged
Merged
Conversation
Author
|
tks codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings across the codebase, focusing mainly on enhancing keyboard dismissal handling in modals, updating reader settings for better customization, and refining UI components. The most significant changes are grouped and summarized below.
Keyboard Dismissal and Modal Behavior Improvements:
useKeyboardModalDismissto usereact-native-keyboard-controllerfor a more robust and asynchronous keyboard dismissal, including a timeout fallback and prevention of duplicate dismiss requests. Modal tests were updated to match this behavior, ensuring modals only dismiss after the keyboard is fully hidden. [1] [2] [3] [4] [5] [6] [7]Reader Settings and Customization:
ChapterReaderSettingsto support paragraph indentation and spacing, migrated legacy custom CSS/JS to code snippets, and added migration logic for seamless upgrades. The settings UI and CSS now reflect these new options for improved reader customization. [1] [2] [3] [4] [5] [6] [7] [8]UI Component Refinements:
ColorPickerModalwith better thumb shapes, rotation, and panel sizing for a more polished look and feel. [1] [2] [3]ToggleButtonto clean up style logic, separating pressable and container styles and ensuring proper opacity handling when disabled. [1] [2]Miscellaneous Enhancements:
chapterElementto the reader's JS core for easier access to the chapter DOM element.TikTokTTSModuleto ensure theonStartevent is sent at the correct time. [1] [2]These changes collectively improve user experience, code maintainability, and the flexibility of customization features in the reader.