Skip to content

refactor: reader settings - #48

Merged
aiko-chan-ai merged 18 commits into
masterfrom
refactor-webview-settings
Jul 19, 2026
Merged

refactor: reader settings#48
aiko-chan-ai merged 18 commits into
masterfrom
refactor-webview-settings

Conversation

@aiko-chan-ai

Copy link
Copy Markdown

This pull request introduces several improvements and refactorings across the codebase, focusing mainly on enhancing keyboard dismissal handling in modals, updating reader settings for better customization, and refining UI components. The most significant changes are grouped and summarized below.

Keyboard Dismissal and Modal Behavior Improvements:

  • Refactored useKeyboardModalDismiss to use react-native-keyboard-controller for a more robust and asynchronous keyboard dismissal, including a timeout fallback and prevention of duplicate dismiss requests. Modal tests were updated to match this behavior, ensuring modals only dismiss after the keyboard is fully hidden. [1] [2] [3] [4] [5] [6] [7]

Reader Settings and Customization:

  • Enhanced ChapterReaderSettings to support paragraph indentation and spacing, migrated legacy custom CSS/JS to code snippets, and added migration logic for seamless upgrades. The settings UI and CSS now reflect these new options for improved reader customization. [1] [2] [3] [4] [5] [6] [7] [8]

UI Component Refinements:

  • Improved the ColorPickerModal with better thumb shapes, rotation, and panel sizing for a more polished look and feel. [1] [2] [3]
  • Updated the ToggleButton to clean up style logic, separating pressable and container styles and ensuring proper opacity handling when disabled. [1] [2]

Miscellaneous Enhancements:

  • Added a new safe property chapterElement to the reader's JS core for easier access to the chapter DOM element.
  • Adjusted TTS event firing in TikTokTTSModule to ensure the onStart event is sent at the correct time. [1] [2]

These changes collectively improve user experience, code maintainability, and the flexibility of customization features in the reader.

@aiko-chan-ai
aiko-chan-ai requested a review from Copilot July 19, 2026 13:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aiko-chan-ai
aiko-chan-ai merged commit 7bd85ce into master Jul 19, 2026
2 checks passed
@aiko-chan-ai

Copy link
Copy Markdown
Author

tks codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants