Fix/everything#178
Open
guopenghui wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the version number of the 'everything' plugin in plugin.json from 2.7.3 to 2.7.4. The reviewer noted that the functional changes described in the pull request, such as icon protocol modifications and callback registration, are missing from the current diff, rendering the PR incomplete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
之前 everything 插件的main push有两个问题:
前者的原因是之前插件里使用了不存在的 nativeicon: 协议,本pr里面换成了直接调用api的方式。
后者的原因是该插件的 onMainPush 没有注册 selectCallback,本pr里面添加了 () => true 作为默认值。
修改后经测试,图标可以正常显示,可以正常按回车进入插件面板。
备注: