Add plugin 窗口置顶 v1.0.0#192
Conversation
- feat: TopWindow plugin v1.0.0 - Windows window always-on-top toggle - fix: add title field to plugin.json for CLI publish
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the topwindow plugin for ZTools, which allows users to toggle the 'Always on Top' status of the active window on Windows systems. The implementation uses a PowerShell script to interface with Win32 APIs via C# interop. The review feedback focuses on improving the robustness of the plugin by handling edge cases in window title parsing, enhancing error diagnostics by capturing stderr from the child process, and ensuring correct character encoding for non-ASCII window titles.
| const parts = output.split('||'); | ||
| const action = parts[0] || ''; | ||
| const title = parts[1] || ''; |
There was a problem hiding this comment.
使用 split('||') 解析输出结果时，如果窗口标题本身包含 || 字符串（虽然少见但可能存在），会导致标题显示不完整。建议使用解构赋值配合 join 来确保获取完整的标题内容。
| const parts = output.split('||'); | |
| const action = parts[0] || ''; | |
| const title = parts[1] || ''; | |
| const [action, ...titleParts] = output.split('||'); | |
| const title = titleParts.join('||'); |
| if (error) { | ||
| console.error('TopWindow exec error:', error.message); | ||
| try { | ||
| window.ztools.showNotification('TopWindow 执行失败: ' + error.message); | ||
| } catch (e) { /* ignore */ } |
There was a problem hiding this comment.
在处理 exec 执行错误时，建议同时记录或显示 stderr 的内容。PowerShell 的具体错误详情（如权限不足、脚本内部错误等）通常会输出到 stderr，这对于排查插件执行失败的原因非常有帮助。
| @@ -0,0 +1,54 @@ | |||
| $code = @' | |||
There was a problem hiding this comment.
建议在脚本开头显式设置输出编码为 UTF-8。由于窗口标题可能包含中文字符，如果 PowerShell 使用默认的系统 ANSI 编码输出，Node.js 在读取 stdout 时可能会出现乱码。
[Console]::OutputEncoding = [System.Text.Encoding]::UTF8
$code = @'
只支持windows系统的话需要添加这个平台标识
|
- feat: TopWindow plugin v1.0.0 - Windows window always-on-top toggle - fix: add title field to plugin.json for CLI publish - feat: 透明背景logo + 添加win32平台标识 + 重新打包 - chore: 添加构建产物plugin.json - docs: 添加CHANGELOG.md - chore: 将build目录加入gitignore并从git中移除
2 participants
插件信息
本次变更
截图 / 演示
自检清单
plugins/topwindow/目录此 PR 由 ztools-plugin-cli 自动管理：每次
ztools publish在分支上追加一个 commit，PR 链接保持不变。