Add plugin Todo v0.0.1#198
Open
guopenghui wants to merge 3 commits into
Open
Conversation
- Initial todo plugin implementation - Split todo store composables - Extract todo interaction composables - Extract todo domain composables - Update plugin documentation and packaging
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive "Todo" plugin for the ztools platform, featuring a Vim-inspired interface, task grouping, search functionality, and specialized desktop components like note windows and a tomato timer. The feedback identifies several critical issues, including encoding errors (Mojibake) and a UTF-8 BOM in NoteWindow.vue, as well as a logic flaw in the useTodoStore composable where lifecycle hooks are used in a way that could cause premature cleanup of global resources. Additionally, improvements are suggested for performance, such as hoisting MarkdownIt instantiation, and for code style regarding redundant .value references in Vue templates.
- Initial todo plugin implementation - Split todo store composables - Extract todo interaction composables - Extract todo domain composables - Update plugin documentation and packaging - Address plugin review feedback
- Initial todo plugin implementation - Split todo store composables - Extract todo interaction composables - Extract todo domain composables - Update plugin documentation and packaging - Address plugin review feedback - Fix task list overflow layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
插件信息
本次变更
截图 / 演示
界面
搜索
Vim 操作
自检清单
plugins/todo-neo/目录此 PR 由 ztools-plugin-cli 自动管理：每次
ztools publish在分支上追加一个 commit，PR 链接保持不变。