Skip to content

feat(setting): 网页快开支持普通网站#505

Open
guopenghui wants to merge 6 commits into
ZToolsCenter:mainfrom
guopenghui:feature/quick-web
Open

feat(setting): 网页快开支持普通网站#505
guopenghui wants to merge 6 commits into
ZToolsCenter:mainfrom
guopenghui:feature/quick-web

Conversation

@guopenghui
Copy link
Copy Markdown
Contributor

@guopenghui guopenghui commented May 18, 2026

变更内容

  • 网页快开支持了普通网站(非搜索引擎)
  • 支持手动上传图标
  • 删除快开时同时删除历史记录、pin、超级面板项
  • 支持设置全局快捷键触发快开

动机

支持普通网站的快速打开

截图

image image

相关 Issue

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new 'Webpage' type to the Web Search feature, allowing users to map specific keywords directly to URLs in addition to using search engine templates. Key changes include UI updates to the settings and editor components, backend support for direct URL opening via Electron's shell API, and a data migration to update legacy configurations to the new typed format. Additionally, the favicon fetching logic was improved with better error handling and a fix for potential decoding issues. Review feedback highlighted a potential issue with character corruption when converting stream chunks to strings in the favicon fetcher, suggesting a more robust decoding approach.

@@ -313,38 +424,18 @@ class WebSearchAPI {
data += chunk.toString()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using chunk.toString() on a stream of data can lead to corrupted characters if a multi-byte character (like UTF-8) is split across chunk boundaries. While likely safe for parsing ASCII-based HTML tags within the first 100KB, it is more robust to use a StringDecoder or collect all chunks before decoding.

Suggested change
data += chunk.toString()
data += chunk.toString('utf8')

@guopenghui guopenghui marked this pull request as ready for review May 18, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 网页快开功能应该作为一个插件被支持 [Feature]建议网页快开功能中增加常规网页类型

1 participant