refactor: Solar as a thin adapter over @lumencast/runtime (ADR 007 §B)#4
Merged
Merged
Conversation
Replaces Solar's in-house stack (transport/state/render/animate/overlay/ modes) with a thin adapter over @lumencast/runtime. Public surface kept: mount / MountOptions / SolarHandle / setToken / disconnect. Reconciled with main@7127025: PR#3's action-runner + PrismScene embed + UMD surface is dropped per ADR 007 escalation #6 (zero consumers in Zab, recoverable from history at 7127025). Removed orphaned #3 files (animate/action-runner, animate/runners/*, animate/easing-resolver, animate/flip, scene/*, transport/protocol, vite.config.umd, finalise-dist, embed examples/docs, CHANGELOG) and reverted package.json UMD/peerDeps/ flip-subpath additions back to the adapter shape.
ClodoCapeo
force-pushed
the
feature/solar-lumencast-runtime
branch
from
1f71cc8 to
29c356d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lumencast convergence (ADR 007 §B).
Summary
Solar becomes a thin adapter over
@lumencast/runtime@0.1.0(real, published, LSML 1.1 + LSDP/1.1 complete) instead of its bespoke RenderBundle/WS stack.Changes
mount()mapsorionUrl→serverUrland delegates. Public surface (MountOptions/SolarHandle/SolarError/setToken/disconnect) byte-stable — Pulsar CEF / Prism / editor unaffected.render/transport/state/animate/modes/overlay(−3984 lines, subsumed by the runtime).SolarErrorCodemaps lossless to@lumencast/protocolErrorCode.Test plan
render.test.tsx: mount end-to-end on a real LSDP/1.1 fake transport. Vigil APPROVE.Note
Supersedes
feature/rich-primitive-parity(hand-rolled gradient/glow/stroke) — that branch is now caduque, do not merge. Follow-upchore/: decouplecheck-bundle-size.mjsfrom runtime chunk names.🤖 Generated with Claude Code