Fix the release workflow so it parses - #159
Merged
Merged
Conversation
Zaneham
added
the
no-changelog-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow that went in with #158 was rejected by GitHub outright, so it never ran. It picked the shell with an expression,
shell: ${{ runner.os == 'Windows' && 'msys2 {0}' || 'bash' }}, and Actions won't take that. A rejected workflow shows up as a zero-second failed run with no jobs and no error message anywhere in the API, which is a miserable thing to work out from the outside.Split into per-OS steps guarded by
if:instead. Everything after the build uses plainbash, which exists on all three runners. GitHub accepts the file now, verified by pushing it and getting no validation failure.