Name tests by family and number, after z390 - #162
Merged
Conversation
Family is the file stem, numbers are two digits, and the old descriptive name became a description the runner prints. th_check refuses to start if a name, number or family does not line up.
Owner
Author
|
Note: Aside from the comments and my general review, Claude was used to help organise the test refractor. I'm overall pretty happy with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are now named
rvi01andtdf39rather thanrv_isel_max_frame_slots_in_range, family per file, two digits so grep and ls agree with the runner about what comes first. The old descriptive name became a description the runner prints, andfam_orderin tmain.c is the one place a family gets declared.The reason for doing it is that 278 of the 380 tests were registering under families
cat_ordernever listed, so they ran unheaded in link order,--listshowed 102 of them, and--cat rv_encran none of them while exiting 0.th_checknow refuses to start on an unknown family, a name that disagrees with its number, or a number already taken.Also brought over from z390: sidecar
.optfiles somake reprodeclares the eight backend refusals it used to swallow as skips (one of them a live v_mfma verifier failure, declared not fixed), atrpi.cfor regressions on bugs that shipped, seeded with #160's line-number corruption which had four sites fixed and no test, and a check that the keyword tablelookup_keywordbinary searches is actually in order.390 tests, 389 pass, 1 pre-existing skip.
make reproclean.