Conversation
Qaomen
left a comment
Qaomen
left a comment
There was a problem hiding this comment.
Wooh more dependency updates! Slightly less wooh is that the cookies and editor are borked, meaning I couldn't fully test the pako dependency update either. :(
| AUTH_CHANGED: 0, | ||
|
|
||
| data: Cookies.getJSON("user_data") | ||
| data: JSON.parse(Cookies.get("user_data")) |
There was a problem hiding this comment.
When I logged out on the client page and refreshed, the page failed to load fully and got this in my console.
| "stats-js": "^1.0.0", | ||
| "styled-components": "^5.1.0", | ||
| "three": "^0.123.0", | ||
| "three": "^0.132.0", |
There was a problem hiding this comment.
It looks like Three.js has breaking changes (which we get warnings about when building the client), causing the editor to break:
|
Heck I'm so smart, probably didn't even rebuild the client after bumping version numbers but before testing. |
(Leaving it unset will be unsupported in the future, causing the cookie to be rejected)
- Also changed editorLog to have messages appear in the regular browser console too.
|
@Qaomen Actually before you approve this, try this map: When you load it, the start & starting gate are slightly offset, until you click the world tab, which causes it to snap back to how they should be positioned. |
2 participants
More dependency updates! Woo! Hopefully this also fixes any open security issues when it comes to dependencies.
Only
Cookieshad breaking changes that affected us, so that logic has been updated.Discord.jsis not updated in this PR because that's done in #301 of course.