core: Mmio helpers and raw access cleanup#990
Open
piotrfila wants to merge 13 commits into
Open
Conversation
Contributor
Author
|
Looks like the esp examples work on debug builds but break with --release=small?? I'll take a look tommorow |
Contributor
Author
|
Main branch has the same issue:( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds helper functions for manipulating Mmio and replaces references to Mmio.raw with raw.read() and raw.write()
This is a prerequisite to making Mmio aware of register access type.
I also tried to generally improve the code I touched by removing direct .raw access.
This made me aware that there is a lot of duplicate code in gpio drivers, maybe we can consolidate them somehow? At least for similar families like stm32/gd32/ch32v