Skip to content

Added new directory to be saved by zmdiaglog introduced into zimbra 8… - #9

Open
DinoPuller wants to merge 1 commit into
Zimbra:developfrom
DinoPuller:develop
Open

Added new directory to be saved by zmdiaglog introduced into zimbra 8…#9
DinoPuller wants to merge 1 commit into
Zimbra:developfrom
DinoPuller:develop

Conversation

@DinoPuller

Copy link
Copy Markdown
Contributor

Added new directory to be saved by zmdiaglog introduced into zimbra 8.8.7 NG

@Prashantsurana

Copy link
Copy Markdown
Contributor

@plobbes @gordyt Please have a look at this.

@plobbes plobbes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong.

Comment thread src/libexec/zmdiaglog
my @network_conf_files = (
"/opt/zimbra/conf/zextras/config",
"/opt/zimbra/conf/zextras/oplog",
"/opt/zimbra/conf/zextras/bulk_delete/*",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what we would typically find under here, but if we're trying to get files under bulk_delete, then we need to use glob() similar to two lines below.

Also, unrelated, but curious... why is a log (oplog) living under /opt/zimbra/conf (and /opt/zimbra/conf/zextras/data/ too)? Logs/data files are typically under /var/log or /opt/zimbra/log or /opt/zimbra/data, but not under config. Sigh.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DinoPuller can you please address review comments?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plobbes The files in the /opt/zimrba/conf/zextras/* are controlled by zxtras. They are separate because they are not part of the core zimbra product. I don't like it either, but that's where they are.

bulk_delete contains a json file with a list of message ids that zextras will delete based on a sweeper process. The sweeper will read the file then delete those blobs. this is how they prevent stale blobs from being in the store, and also prevent large delete requests from impacting the server.

We could ask them to move the files, no problem with that. but the files added by @DinoPuller could be useful, as we had a case today where I needed them.

If you can, anything recursively in the /opt/zimbra/conf/zextras dir would be incredibly useful for zmdialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants