Fix build against current AzerothCore API (hook signature changes) - #3
Open
holmax009-glitch wants to merge 1 commit into
Open
Conversation
Two PlayerScript/ServerScript hook signatures changed in current AzerothCore master and broke the build (C3668/C4263/C4264): - PlayerScript::OnPlayerResurrect: 3rd param is now `bool&` (was `bool`) - ServerScript::CanPacketReceive: packet param is now `const WorldPacket&` (was `WorldPacket&`) Update the overrides accordingly. Bodies are unaffected: applySickness was already unused, and CanPacketReceive only calls packet.GetOpcode() (const), so making the packet const is safe. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mod-hardcore fails to compile against current AzerothCore master with
C3668/C4263/C4264onOnPlayerResurrectandCanPacketReceive. Two core hook signatures changed:PlayerScript::OnPlayerResurrectnow takesbool& applySickness(wasbool)ServerScript::CanPacketReceivenow takesconst WorldPacket&(wasWorldPacket&)Fix
Update the two overrides to match. Behavior is unchanged:
applySicknesswas already unused (commented out)CanPacketReceiveonly callspacket.GetOpcode()(const), so const-qualifying the ref is safeTesting
ModHardcore.Enable = 1); module config loads and the server reaches ready state