Skip to content
This repository was archived by the owner on Jul 17, 2020. It is now read-only.

Export import#215

Open
BobVul wants to merge 4 commits into
Zirak:masterfrom
BobVul:export-import
Open

Export import#215
BobVul wants to merge 4 commits into
Zirak:masterfrom
BobVul:export-import

Conversation

@BobVul

@BobVul BobVul commented Sep 10, 2014

Copy link
Copy Markdown
Contributor

Add export and import commands using the GitHub Gist API for storage. Issue #158.

@BobVul

BobVul commented Sep 10, 2014

Copy link
Copy Markdown
Contributor Author

@allquixotic

Copy link
Copy Markdown

+1

2 similar comments
@drpatil78

Copy link
Copy Markdown

+1

@SomeKittens

Copy link
Copy Markdown
Contributor

+1

@benjamingr

Copy link
Copy Markdown
Contributor

I think that clearing the memory should automatically back it up to a gist to prevent mishaps.

Other than that good commit, clean.

@BobVul

BobVul commented Sep 11, 2014

Copy link
Copy Markdown
Contributor Author

@benjamingr I'm not sure what would be the best way to implement that. Extract export into a separate function, or chain the command?

var exportResult = bot.commands['export'].exec();

bot.memory.clear();

return exportResult + ' Bot memory cleared. Please restart the bot.';

Might also be a good idea to clear before importing new data, since the import .save() doesn't clear/overwrite bot_ localStorage entries that don't exist in the new data.

@AmaanC

AmaanC commented Sep 11, 2014

Copy link
Copy Markdown
Contributor

Yeah, an import should probably clear old data
On Sep 11, 2014 2:55 PM, "Bob" notifications@github.com wrote:

@benjamingr https://github.com/benjamingr I'm not sure what the best
way to implement that is. Extract export into a separate function, or chain
the command?

var exportResult = bot.commands['export'].exec();
return exportResult + ' Bot memory cleared. Please restart the bot.';

Might also be a good idea to clear before importing new data, since the
import .save() doesn't clear/overwrite bot_ localStorage entries that
don't exist in the new data.


Reply to this email directly or view it on GitHub
#215 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants