Fixed some tests that would not pass, fixed some shellcheck warnings, used shellformat to format script#6
Open
speedythesnail wants to merge 4 commits intoZordrak:masterfrom
Open
Conversation
Fix tests, update potential logs paths (if no messages file, then use syslog)
Change lowercase from using a subprocess, to using native bash variable manipulation. shellformat
Fix script_name variable that may modify it for scripts sourcing this library. Hopefully name is unlikely to be used by someone else.
Fix grep for script log, should be ^*log.sh and not ^log.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I appreciate this logging framework, thank you much!
I apologize for the massive diff due to running shellformat. It's a great plugin that I use to keep all my scripts clean and tidy.