Refactor normalization handling and add ApplyPostNormalizeTransform#35
Open
struckchure wants to merge 2 commits intoa-h:mainfrom
Open
Refactor normalization handling and add ApplyPostNormalizeTransform#35struckchure wants to merge 2 commits intoa-h:mainfrom
struckchure wants to merge 2 commits intoa-h:mainfrom
Conversation
Refactor normalization logic to store result in a variable before returning.
Author
|
Maybe it might be worth considering as part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Use case
I have 3 types of the same struct name as a response model, it became a problem quickly, cause they were overriding each other (in order, i think).
With the current implement, you get just 1 Response and the rest is just gone.
Proposed Solution
now, i'll have
OneReponse,TwoResponseandThreeResponseImplementation Details
This pull request introduces a new hook to allow post-processing of normalized type names in the API schema generation logic. The main change is the addition of a configurable function that can be used to further transform normalized names after the default normalization logic has been applied.
Enhancements to type name normalization:
ApplyPostNormalizeTransformfunction field to theAPIstruct inapi.go, allowing custom post-processing of normalized type names.normalizeTypeNamemethod inschema.goto callApplyPostNormalizeTransformif it is set, enabling additional transformation of the normalized string before returning it.