This repository was archived by the owner on Feb 23, 2026. It is now read-only.
ci: fix script injection in outcome job#22
Draft
persimmon16 wants to merge 1 commit intojolt/1.89.0from
Draft
Conversation
Move toJson(needs) from inline run: expression to env: variable to prevent shell metacharacter injection via crafted job outputs. Wiz Issue: 16f1da6f-ae19-4da7-9122-1f3e33ba5e10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates a GitHub Actions script injection vulnerability (CWE-78) in the CI workflow's
outcomejob, identified by Wiz as issue16f1da6f-ae19-4da7-9122-1f3e33ba5e10(HIGH severity).The
toJson(needs)expression was interpolated directly into an inlinerun:script via a single-quoted here-string. Because${{ }}expressions are evaluated before the shell parser, any single-quote character in aneedsoutput value (e.g., derived from a crafted commit message processed throughcalculate_matrix) would terminate the quoted string and yield arbitrary shell execution on the runner.Fix: Move
toJson(needs)to anenv:block and reference the resulting shell variable. The runner's environment variable API sets the value without shell interpolation, eliminating the injection vector entirely.Change
References
16f1da6f-ae19-4da7-9122-1f3e33ba5e10wc-id-3075— Publicly exposed code repository with workflow script injection