Skip to content

refactor(web_core): move web_core package to typescript/web_core - #2300

Merged
gspencergoog merged 6 commits into
v1_0from
v1_0_firing_rename
Aug 17, 2026
Merged

refactor(web_core): move web_core package to typescript/web_core#2300
gspencergoog merged 6 commits into
v1_0from
v1_0_firing_rename

Conversation

@gspencergoog

Copy link
Copy Markdown
Collaborator

Move web_core package from renderers/web_core to typescript/web_core and update all workspace dependencies, wireit build targets, and documentation references.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request relocates the framework-agnostic web_core package from renderers/web_core to typescript/web_core. It updates all associated references, including documentation, blueprints, workspace configurations, package dependencies, and lockfiles, to reflect the new directory structure. There are no review comments, and I have no feedback to provide.

@gspencergoog
gspencergoog requested a review from nan-yu August 17, 2026 16:34

@nan-yu nan-yu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change CI for the web_core move?

We need to add the typescript/web_core/ into https://github.com/a2ui-project/a2ui/blob/main/.github/workflows/web_ci.yml.

@gspencergoog

Copy link
Copy Markdown
Collaborator Author

Do we need to change CI for the web_core move?

We need to add the typescript/web_core/ into main/.github/workflows/web_ci.yml.

Yes, good point. I should have checked that... I've updated that now.

@gspencergoog
gspencergoog merged commit a457cdc into v1_0 Aug 17, 2026
13 checks passed
@gspencergoog
gspencergoog deleted the v1_0_firing_rename branch August 17, 2026 17:32
@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants