cleanup(swift): Fix some formatting issues - #2302
Open
pinieb wants to merge 3 commits into
Open
Conversation
I forgot to push these changes with my last PR, but they also should have been caught by `fix_format.sh` in presubmit. This change also ensures that Swift is installed on the action runner so that Swift formatting issues can be caught in the `format-check` presubmit.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily applies formatting and style updates across several Swift files, including renaming OpenUrlFunction to OpenURLFunction and updating its corresponding tests. The reviewer feedback suggests changing OpenURLFunction from a struct to a final class to safely handle class-bound handler references, and adding non-negativity checks for the decimals parameter in both FormatCurrencyFunction and FormatNumberFunction before configuring the number formatters.
pinieb
marked this pull request as ready for review
August 17, 2026 18:13
pinieb
enabled auto-merge (squash)
August 17, 2026 18:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to push these changes with my last PR, but they also should have been caught by
fix_format.shin presubmit. This change also ensures that Swift is installed on the action runner so that Swift formatting issues can be caught in theformat-checkpresubmit.