feat(web_core): expand conformance suite coverage and unskip tests - #2315
feat(web_core): expand conformance suite coverage and unskip tests#2315gspencergoog wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements support for normalizing v0.8 components, handles structured contents in data model updates, and falls back to the first catalog if catalogId is omitted. It also updates several conformance tests to validate these changes. The review feedback suggests several improvements for robustness: ensuring normalizeV08Component returns a safe fallback object and uses unknown instead of any; avoiding the spread operator to prevent property collisions; using the in operator instead of nullish coalescing to preserve explicit null values in data model updates; and replacing truthiness checks with nullish coalescing or explicit undefined checks to prevent valid falsy values (like 0 or empty strings) from being incorrectly overridden.
e215045 to
ca7971f
Compare
…ation and catalog fallback
…ip all conformance tests
ca7971f to
d1423fa
Compare
Summary
Implements graph topology validation and strict schema mode in TypeScript web core to achieve 100% conformance test suite pass rate with zero skipped tests.
Changes
validateTopologygraph integrity checks (missing root component,circular reference detected,dangling reference,orphaned component).strictMode: trueoption is passed.size,keys, andvaluesaccessors to support component collection inspection during topology graph traversal.conformance_test.mjs):jsonSchemaToZodconverter for dynamic YAML test catalog component and theme definitions.strictMode: Boolean(testCase.strictMode)toMessageProcessor.SKIP_TEST_NAMESso all 221 conformance test vectors execute and pass.Impact & Risks
221/221) now run and pass successfully.strictMode.Testing
Run unit tests:
yarn --cwd typescript/web_core testVerify 291/291 unit tests pass.
Run conformance harness:
Verify 221/221 test cases pass with 0 failed and 0 skipped.