fix(renderers): loosen client-side component validation to allow unknown properties - #2325
Open
nan-yu wants to merge 11 commits into
Open
fix(renderers): loosen client-side component validation to allow unknown properties#2325nan-yu wants to merge 11 commits into
nan-yu wants to merge 11 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request loosens client-side component validation across Angular, Lit, React, Web Core, and Swift renderers to support unrecognized and legacy component properties without throwing errors. This is done by removing .strict() from Zod schemas in Web Core, filtering out unrecognized_keys validation issues in MessageProcessor, and updating binders to pass through unrecognized properties. The reviewer noted that filtering only unrecognized_keys at the top level in MessageProcessor is insufficient when a component schema uses z.union of strict objects, as unrecognized keys will result in an invalid_union error instead, and suggested recursively checking unionErrors.
…own properties Loosens client-side component validation so older messages and unrecognized properties do not throw validation errors when rendered on the client: - Removes .strict() from all v0.9 basic component Zod schemas in web_core. - Filters out unrecognized_keys issues during MessageProcessor component validation. - Confirms GenericBinder, Angular ComponentBinder, and Swift MessageProcessor treat unrecognized properties as static/inert values. - Adds comprehensive unit and integration tests across web_core, React, Lit, Angular, and Swift test suites. - Updates CHANGELOGs for web_core, Angular, Lit, and React packages.
…rors in MessageProcessor Addresses review feedback on PR a2ui-project#2325 by adding filterZodRealIssues to recursively check unionErrors when evaluating invalid_union issues, ensuring that unrecognized keys on union branches of strict schemas are properly ignored during client-side validation.
nan-yu
force-pushed
the
relax-validation
branch
from
August 18, 2026 17:15
7128016 to
bf277c5
Compare
wrenj
reviewed
Aug 18, 2026
wrenj
reviewed
Aug 18, 2026
…onent types Adds tests across web_core, React, Lit, Angular, and Swift to verify that unrecognized component types: - Are accepted by MessageProcessor without throwing validation errors. - Degrade gracefully in React, Lit, Angular, and SwiftUI views without crashing or breaking surrounding component rendering.
- Fix Swift Testing macro failure on Optional<AnyView> comparison. - Allow Swift MessageProcessor to accept and store unrecognized components gracefully. - Add warning logs for unrecognized components and unrecognized property keys in both TypeScript and Swift MessageProcessors. - Add extractUnrecognizedKeys helper to recursively extract unrecognized keys from union branches. - Fix catalog ID injection in Angular unrecognized component integration test.
wrenj
reviewed
Aug 18, 2026
| surfaceId: 'test-surface', | ||
| components: [ | ||
| { | ||
| id: 'root', |
Collaborator
There was a problem hiding this comment.
I guess we should do it for functions too?
Collaborator
There was a problem hiding this comment.
and any other things in the catalog that could get out of date?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loosens client-side component schema validation across renderers so that messages containing unrecognized properties (such as older conversation history or forward-compatible properties) render without throwing validation errors. Agent-side payload validation remains strict (
additionalProperties: false).Changes
@a2ui/web_core:.strict()from all basic component Zod schemas (TextApi,ButtonApi,TextFieldApi,SliderApi, etc.).MessageProcessor.processUpdateComponentsMessageto filter outunrecognized_keysZod validation issues while continuing to reject invalid property types.GenericBindertreats unrecognized properties as static values in reactive snapshots.@a2ui/react,@a2ui/lit,@a2ui/angular, andA2UISwiftUItolerate unrecognized component properties without rendering or lifecycle issues.@a2ui/web_core,@a2ui/react,@a2ui/lit,@a2ui/angular, andswift/core.CHANGELOG.mdfiles for@a2ui/web_core,@a2ui/angular,@a2ui/lit, and@a2ui/react.Verification
yarn test:all: All workspace test suites passed.yarn lint:all: Linters passed.yarn format:check:all: Formatting checks passed.