Fix the gtag function. - #164
Open
jgindin wants to merge 2 commits into
Open
Conversation
Previously, we were pushing the arguments as an array, but that's not correct and prevents the data from being sent.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Ga4UsageTrackingService to push the arguments object directly to windowObj.dataLayer instead of using rest parameters. The review feedback suggests maintaining the rest parameters in the function signature for consistency with the Window interface declaration, and requests adding unit tests to verify this change in accordance with the repository style guide.
Contributor
⚡ A2UI Composer PR PreviewYour automated preview is successfully live (commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, we were pushing the arguments as an array, but that's not correct and prevents the data from being sent.
Pre-launch Checklist