feat: add status subresource to ConstraintTemplatePodStatus CRD#1
Closed
a7i wants to merge 1 commit into
Closed
Conversation
Declare a Kubernetes status subresource on ConstraintTemplatePodStatus and switch the ConstraintTemplate reconciler to write pod status via Status().Update instead of a full-object Update. This aligns the write path with other Gatekeeper controllers that update status subresources. It does not replace the stale-cache conflict retry in open-policy-agent#4596; Status().Update still requires a current resourceVersion. Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
Owner
Author
|
Superseded by upstream PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
+kubebuilder:subresource:statustoConstraintTemplatePodStatusand regenerates the CRD/manifests.Status().Updateinstead of full-objectUpdate.Separate from open-policy-agent#4596: this changes the write API path to the conventional status subresource. It does not address stale informer cache conflicts on its own; that still needs the retry/refetch logic in open-policy-agent#4596.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to open-policy-agent#4595
Special notes for your reviewer:
subresources.status: {}); existing stored objects are unchanged.make manifestsrequires Docker locally; CICheck codegen and manifestshould validate.Status().Updateinstead ofUpdate.Made with Cursor