Add error logging#48
Open
NickGreen wants to merge 27 commits into
Open
Conversation
Contributor
Author
|
Noting here that I've removed the block of code which Eseban added previously, because I don't think it's correct: // We've got a release date. That release date could be 10 days ago. So instead of adding extra days,
// make a calculation here to see if time() > $release_date + $delay_days. If so, the update version time is now.
if ( time() > $release_plus_delay ) {
$release_plus_delay = time();
}But worth going there if we end up with delay calculation issues. My understanding is that our desired behavior is: If we have a release date:
If we don't have a release date:
|
Contributor
Author
|
Protip: if you have this installed on a site and want to test it, but don't want to wait for the |
Contributor
Author
|
Suggested additions:
|
Contributor
Author
|
Logs currently look like this: |
SO that if a store is connected to WooCommerce.com, we know the package is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Example log entry
Screenshot
Testing
There are significant architectural changes to the plugin, so we need to test on a real site for a little while before merging to trunk.