Keep URL params when fetching posts, fix incorrect page parameters and improve infinite scroll#57
Conversation
…t the bottom of the viewport; - Fix - Page parameter for inherited queries; - Fix - Page parameter for custom query page when not set; - Fix - Keep current URL parameters when fetching new posts and updating the location URL. - Updated version to 1.0.17
WalkthroughThis pull request updates package and metadata to version 1.0.17, updates documentation/changelog, adds a PHP_CodeSniffer exclude-pattern to skip /tests/, introduces a top-level JS helper Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/Plugin.php`:
- Around line 252-266: The expression setting $query_id can trigger an
undefined-index notice because the (int) cast has higher precedence than the ??
operator; change the assignment to cast the result of the null-coalescing
expression (e.g. (int) ($block->context['queryId'] ?? 0)) so the array access is
protected by ?? before casting, and verify related uses ($page_key, $inherit,
and the $page calculation) still use $query_id / isset checks consistently.
🧹 Nitpick comments (1)
assets/js/src/index.js (1)
243-246: LGTM - improved help text with practical example.The updated help text provides clearer context for users about what the "Update URL" option does.
Minor style nit: Consider removing the extra spaces inside parentheses
( e.g.: ... )→(e.g., ...)for consistency with typical English punctuation conventions.
…the document instead of each individual button
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@README.md`:
- Line 42: The changelog sentence is missing a connector; update the entry "*
Fix - potential issue infinite scroll not triggering if button is at the bottom
of the viewport" to read clearly, e.g. "* Fix - potential issue where infinite
scroll was not triggering if the button is at the bottom of the viewport" (or
insert "where" after "issue" and adjust tense to "was not triggering") so the
sentence is grammatical and clear.
🧹 Nitpick comments (1)
README.md (1)
45-45: Consider using past tense for consistency.The changelog entry uses "Keep" while other entries use past tense verbs like "Fixed", "Changed", or "Kept" for consistency.
📝 Proposed fix
-* Fix - Keep current URL parameters when fetching new posts and updating the location URL +* Fix - Kept current URL parameters when fetching new posts and updating the location URL
nate-allen
left a comment
There was a problem hiding this comment.
Looks good! No changes needed. Thank you 😄
Thank you for for creating issues and offering solutions:
@agarciar
@TCCJackson
@jbouganim
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.