Positional Parameter Support#30
Open
rodriguise wants to merge 2 commits intoa8m:masterfrom
Teralytic:master
Open
Positional Parameter Support#30rodriguise wants to merge 2 commits intoa8m:masterfrom Teralytic:master
rodriguise wants to merge 2 commits intoa8m:masterfrom
Teralytic:master
Conversation
Contributor
|
I initially thought this was better outside but it makes it really hard to support operations with question marks in them for postgres like the jsonb operator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides support for:
$rather than?)FilterExp, i.e. (name = $1, age = $2).There are set via two new
Configparameters:{ ParamSymbol string PositionalParams bool }Addionally, a
ConfigparameterParamOffset intis also provided.This supports the use case where the FilterExp is appended to a larger expression and is not the initial parameter set for example:
where
params.FilterExpwould beid=$9Ultimately this allows for the use of this library to create statements directly compatible with Postgres and other dialects that use positional parameters.
Test Cases
Some of the internal testing methods had to be modified to support both of these use cases, namely the
splitfunction that only supported the?character. This was modified to support any character as well as handle positional arguments by ignoring digits post the parameter symbol.