fix(plot): align points array order with cluster labels#30
Merged
Conversation
Points were built grouped-by-cluster while cluster_labels stayed in original data order, causing get_cluster_detail and sub_cluster endpoints to return wrong items for each cluster group. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Verify points array aligns with cluster_labels and original ID order. Integration test uses interleaved labels to catch index mismatch between points and cluster_labels. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Tests Report 📄Tests Succees ✅JUnit Details
Coverage Details (100% >= 90%) ✅Diff Cover Details
|
||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pointsarray was built grouped-by-cluster (all cluster 0 first, then cluster 1, etc.) whilecluster_labelsstayed in original data order, causing index mismatches inget_cluster_detailandsub_clusterendpoints.compute_plot_data()to buildpointsin original data order sopoints[i],cluster_labels[i], andembeddings_standardized[i]all refer to the same item.Verification