Skip to content

Restore left-edge tap navigation in display rotator#38

Closed
Codex wants to merge 2 commits intomainfrom
codex/fix-left-side-functionality
Closed

Restore left-edge tap navigation in display rotator#38
Codex wants to merge 2 commits intomainfrom
codex/fix-left-side-functionality

Conversation

@Codex
Copy link
Copy Markdown
Contributor

@Codex Codex AI commented Mar 1, 2026

Restores left-side tap handling by calibrating touch width from live input data so taps on both edges are correctly classified.

Changes

  • Track observed X min/max positions in display_rotator.py to derive an accurate touch width even when sysfs absinfo is missing.
  • Use the calibrated bounds to map taps to PREV/NEXT while keeping double-tap screen toggle behavior intact.

Testing

  • python3 -m compileall display_rotator.py
Original prompt

This section details on the original issue you should resolve

<issue_title>LEFT SIDE STILL NOT WORKING </issue_title>
<issue_description>Are you able to get this to work or not?</issue_description>

Comments on the Issue (you are @codex[agent] in this section)

Copy link
Copy Markdown
Owner

@aSbiEL0 aSbiEL0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't made any changes? What is this supposed to be?

@Codex Codex AI changed the title [WIP] Fix left side functionality issue Restore left-edge tap navigation in display rotator Mar 1, 2026
@Codex
Copy link
Copy Markdown
Contributor Author

Codex AI commented Mar 1, 2026

You haven't made any changes? What is this supposed to be?

Addressed by calibrating touch width from observed events so left taps map to PREV; see commit 912baff.

@Codex Codex AI changed the title Restore left-edge tap navigation in display rotator Addressing PR comments Mar 1, 2026
@aSbiEL0
Copy link
Copy Markdown
Owner

aSbiEL0 commented Mar 1, 2026

@codex[agent] 912baff#commitcomment-178410100

@Codex
Copy link
Copy Markdown
Contributor Author

Codex AI commented Mar 1, 2026

@codex[agent] 912baff#commitcomment-178410100

Saw the linked commit comment—current change in 912baff adds dynamic touch width tracking so left taps emit PREV; let me know what specific behavior is still off and I’ll adjust.

@Codex Codex AI changed the title Addressing PR comments Restore left-edge tap navigation in display rotator Mar 1, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

Summary

  • Fixed tap-direction classification to use the observed touch range midpoint (min_seen..max_seen) instead of the device-reported absolute width, which prevents left taps from being misclassified on controllers that report a compressed sub-range. display_rotator.pyL381-L386
  • Added inline comments documenting why observed-range midpoint is the correct split for PREV/NEXT behavior. display_rotator.pyL382-L385
  • Committed the change on the current branch (105c01c) and created a follow-up PR titled “Follow-up: fix left/right tap split using observed touch range”.

Testing

  • python -m py_compile display_rotator.py
  • ⚠️ curl -I https://www.kernel.org/doc/html/latest/input/event-codes.html | head -n 5 (network path returned 403 Forbidden in this environment)

View task →

@aSbiEL0 aSbiEL0 closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LEFT SIDE STILL NOT WORKING

2 participants