fix: correct ReplicatedImageRegistry usage per EC3 docs - #49
Merged
Conversation
- Pass only registry host to ReplicatedImageRegistry (not full image ref) - Remove all ReplicatedImageRepository usage (not a documented function) - Use HelmValue for SDK subchart registry to read chart default - Split image.registry from image.repository in values.yaml - Update deployment template to use registry/repository split consistently Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrote image registry handling based on verbatim EC3 template functions docs:
ReplicatedImageRegistrytakes only the registry host (ghcr.io,index.docker.io) — not a full image referenceReplicatedImageRepositoryis not a documented function — removed all usageHelmValue(".replicated.image.registry")for SDK subchart so it reads the chart's own default (proxy.replicated.com), which is returned unchanged for online and redirected to local registry for airgapimage.repositoryinvalues.yamlso it no longer includes the registry hostregistry/repositorysplit consistentlyInstall path verification
ghcr.io/aa-replicated/gameshelf:tagproxy.replicated.com/proxy/gameshelf/ghcr.io/aa-replicated/gameshelf:tagproxy.replicated.com/proxy/gameshelf/ghcr.io/aa-replicated/gameshelf:tag<local-registry>/aa-replicated/gameshelf:tagproxy.replicated.com/library/replicated-sdk-image:tag<local-registry>/library/replicated-sdk-image:tagTest plan
🤖 Generated with Claude Code