Add chat history search feature to navigation panel#8448
Add chat history search feature to navigation panel#8448vincenzopalazzo wants to merge 5 commits intoaaif-goose:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbb808d577
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vincenzopalazzo
force-pushed
the
feature/chat-history-search-clean
branch
from
bbb808d to
cedfeaf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cedfeaf879
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vincenzopalazzo
force-pushed
the
feature/chat-history-search-clean
branch
2 times, most recently
from
6a11bf3 to
667af9c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 667af9c78e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0d7d23aa0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vincenzopalazzo
force-pushed
the
feature/chat-history-search-clean
branch
from
c0d7d23 to
1f3b121
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f3b121278
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 314dcdbaec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 310bc157f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thanks @vincenzopalazzo! Nice work! There's one outstanding Codex comment about closing the Also can you please
After you've finish, I will finalise this PR |
|
Addressed the remaining Codex thread in 310bc15: the chat history search dropdown now closes when focus leaves via keyboard, including Tab-out. I also updated the PR description with Preview and Testing sections. Testing run: I wasn't able to attach a screenshot/video from this CLI environment, so that part still needs a manual follow-up if you'd like it before merge. |
|
Validation complete. Ran:
Current PR checks summary: |
|
Resolved the remaining review thread for the chat history search dropdown keyboard-focus fix. The thread is now marked as resolved. |
Implement a search bar in the Goose navigation panel that allows users to search through their chat history by keywords. Features: - Debounced search (250ms) via /sessions/search endpoint - Results dropdown with session name, message count, relative time - Session status indicators (streaming, unread, error) - Recipe/chat icon distinction - Full keyboard navigation (arrow keys, Enter, Escape) - Cmd/Ctrl+K global shortcut to focus - Animated dropdown with framer-motion - Skeleton loading states - Proper ARIA combobox/listbox accessibility - Hidden in condensed icon-only mode - Works in both expanded grid and condensed layouts - i18n messages extracted and compiled Resolves aaif-goose#8440 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Drop previous results and flip to the searching state as soon as the
query changes so that during the 250ms debounce window:
- items from the previous query can no longer be clicked (misnavigation)
- the empty-state ("No chats found") does not flicker before the new
request actually runs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The global Cmd/Ctrl+K handler previously fired on both `metaKey` and `ctrlKey` across all platforms, so on macOS `Ctrl+K` was intercepted (conflicting with native text-editing behaviour) and the inline hint always displayed `⌘K` even on Linux/Windows. Match the platform convention used elsewhere in the codebase: Cmd on macOS, Ctrl otherwise, and render the hint accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
feature/chat-history-search-clean
branch
from
310bc15 to
1aee503
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1aee5035f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Follow-up on review 4164115220: rebased the branch onto the updated main, kept the chat history search blur fix in 1aee503, and resolved the remaining review thread tied to this review. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
|
Done @lifeizhou-ap now should be ready for another pass! |
2 participants
Add chat history search to navigation panel
Implements a native search bar in the Goose navigation panel, allowing users to search through their chat history by keywords.
Resolves #8440
Features
/sessions/searchbackend endpointCmd/Ctrl+Kto focus the search inputaria-expanded,aria-selectedChanges
components/conversation/ChatHistorySearch.tsxcomponents/Layout/ExpandedRenderer.tsxcomponents/Layout/CondensedRenderer.tsxImplementation Details
ScrollArea,Skeleton,SessionIndicatorsgetSessionDisplayName,truncateMessagefromuseNavigationSessionsdefineMessages/useIntli18n pattern consistent with codebase/sessions/searchendpoint already existsPreview
Quality Checks
Testing
source bin/activate-hermit && cd ui/desktop && pnpm run lint:check