We have completely refactored how agents communicate with server over… - #6
Open
aaronlmathis wants to merge 1 commit into
Open
We have completely refactored how agents communicate with server over…#6aaronlmathis wants to merge 1 commit into
aaronlmathis wants to merge 1 commit into
Conversation
… GRPC by implementing OpenTelemetry standards. In addition, we have updated data structures to mesh with the refactor of resource discovery / caching / labeling on the server.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the tagging fields on log entries to use “labels” instead of “tags,” updates dependency versions, and refreshes generated docs for new OTLP converters and configuration additions.
- Renamed
Tags→Labelsin Linux log collectors to align with new data model - Bumped
gosight-sharedmodule version and added blank-line cleanup in gRPC connection file - Added generated docs for
otelconvert, updated protohelper links, and introducedEventViewerConfigin config docs
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/logs/logcollector/linux/security_linux.go | Rename Tags field to Labels |
| internal/logs/logcollector/linux/journald_linux.go | Rename tags variable to labels |
| internal/grpc/connection.go | Remove stray blank line before WaitForResume |
| go.mod | Bump github.com/aaronlmathis/gosight-shared version |
| docs/internal/protohelper/README.md | Update function link anchors |
| docs/internal/otelconvert/README.md | Add generated OTLP conversion docs |
| docs/internal/metrics/metricsender/README.md | Adjust MetricSender docs and link offsets |
| docs/internal/meta/README.md | Change “Tags” references to “Labels” |
| docs/internal/logs/logsender/README.md | Update LogSender docs to describe OTLP behavior |
| docs/internal/logs/logcollector/windows/README.md | Update NewEventViewerCollector signature |
| docs/internal/grpc/README.md | Adjust gRPC doc link line numbers |
| docs/internal/config/README.md | Introduce EventViewerConfig and update links |
| docs/internal/README.md | Add otelconvert to module index |
| Makefile | Add build/test/run targets |
Comments suppressed due to low confidence (2)
internal/logs/logcollector/linux/security_linux.go:315
- Renaming the
Tagsfield toLabelschanges the serialized JSON schema for log entries. Consider adding or updating structjsontags to preserve backward compatibility or updating all downstream consumers to handle the newlabelsfield.
Labels: map[string]string{
internal/logs/logcollector/linux/journald_linux.go:376
- The variable
tagswas renamed tolabels, which may affect any serialization or filtering logic expectingtags. Ensure that all code paths and documentation have been updated to use the newlabelsfield.
labels := map[string]string{
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… GRPC by implementing OpenTelemetry standards. In addition, we have updated data structures to mesh with the refactor of resource discovery / caching / labeling on the server.