Skip to content

We have completely refactored how agents communicate with server over… - #6

Open
aaronlmathis wants to merge 1 commit into
mainfrom
Refactor/OTLP
Open

We have completely refactored how agents communicate with server over…#6
aaronlmathis wants to merge 1 commit into
mainfrom
Refactor/OTLP

Conversation

@aaronlmathis

Copy link
Copy Markdown
Owner

… GRPC by implementing OpenTelemetry standards. In addition, we have updated data structures to mesh with the refactor of resource discovery / caching / labeling on the server.

… GRPC by implementing OpenTelemetry standards. In addition, we have updated data structures to mesh with the refactor of resource discovery / caching / labeling on the server.
@aaronlmathis
aaronlmathis requested a review from Copilot May 29, 2025 18:57
@aaronlmathis aaronlmathis self-assigned this May 29, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the tagging fields on log entries to use “labels” instead of “tags,” updates dependency versions, and refreshes generated docs for new OTLP converters and configuration additions.

  • Renamed TagsLabels in Linux log collectors to align with new data model
  • Bumped gosight-shared module version and added blank-line cleanup in gRPC connection file
  • Added generated docs for otelconvert, updated protohelper links, and introduced EventViewerConfig in config docs

Reviewed Changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/logs/logcollector/linux/security_linux.go Rename Tags field to Labels
internal/logs/logcollector/linux/journald_linux.go Rename tags variable to labels
internal/grpc/connection.go Remove stray blank line before WaitForResume
go.mod Bump github.com/aaronlmathis/gosight-shared version
docs/internal/protohelper/README.md Update function link anchors
docs/internal/otelconvert/README.md Add generated OTLP conversion docs
docs/internal/metrics/metricsender/README.md Adjust MetricSender docs and link offsets
docs/internal/meta/README.md Change “Tags” references to “Labels”
docs/internal/logs/logsender/README.md Update LogSender docs to describe OTLP behavior
docs/internal/logs/logcollector/windows/README.md Update NewEventViewerCollector signature
docs/internal/grpc/README.md Adjust gRPC doc link line numbers
docs/internal/config/README.md Introduce EventViewerConfig and update links
docs/internal/README.md Add otelconvert to module index
Makefile Add build/test/run targets
Comments suppressed due to low confidence (2)

internal/logs/logcollector/linux/security_linux.go:315

  • Renaming the Tags field to Labels changes the serialized JSON schema for log entries. Consider adding or updating struct json tags to preserve backward compatibility or updating all downstream consumers to handle the new labels field.
Labels: map[string]string{

internal/logs/logcollector/linux/journald_linux.go:376

  • The variable tags was renamed to labels, which may affect any serialization or filtering logic expecting tags. Ensure that all code paths and documentation have been updated to use the new labels field.
labels := map[string]string{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants