feat: abapGit roundtrip - export, deploy, and structure support

[ThePlenkov]

Summary

End-to-end abapGit roundtrip capability: export ABAP objects from SAP to abapGit-format XML/ABAP files, then deploy them back to the system. This PR adds new DDIC object handlers, structure (TABL/DS) support, and the roundtrip/activate CLI commands.

ADK (packages/adk)

• Registry: resolveType() with full-type-first fallback — TABL/DS resolves to AdkStructure, CLAS/OC falls back to CLAS → AdkClass
• Registry: getMainType() helper and getObjectUri() using resolveType()
• Model: crudContract-based load()/save(), lock()/unlock(), activate() lifecycle
• ObjectSet: deploy() with two-phase save+activate, BulkSaveResult tracking (success/failed/unchanged)
• Save lifecycle: Pre-lock comparison phase — checkPendingSourcesUnchanged() skips lock+PUT if sources are identical on server
• TABL: AdkTable (endpoint /ddic/tables/) and AdkStructure (endpoint /ddic/structures/) models with source support
• DOMA/DTEL/TTYP: ADK models with CRUD contract endpoints
• DEVC: Preserve full ADT type string (TABL/DS) instead of stripping subtypes — fixes structure import via wrong endpoint
• CLAS/INTF/PROG/FUGR: savePendingSources() and checkPendingSourcesUnchanged() overrides for skip-unchanged support

abapGit Plugin (packages/adt-plugin-abapgit)

• XSD schemas: Reorder DD02V/DD03P elements to match standard abapGit field ordering (builder uses XSD definition order)
• XSD schemas: Add DD04V fields (DDLANGUAGE, DDTEXT, DOMNAME, etc.) for data elements
• Codegen: Regenerate all schemas and TypeScript types from updated XSDs
• DOMA handler: Domain value serialization with DD01V and DD07V_TAB (fixed values)
• DTEL handler: Data element metadata serialization with DD04V
• TABL handler: Table handler (TABL/DT) and structure handler (TABL/DS) with DD02V + DD03P_TABLE serialization
• TTYP handler: Table type serialization with DD40V
• CDS converter (cds-to-abapgit.ts): Transform CDS-sourced table metadata to classic abapGit DD02V/DD03P format
• Base handler: Use getMainType() for file extension so TABL/DS → .tabl.xml (not .tabl/ds.xml)
• Deserializer: Use payload.type when available for correct subtype resolution during deploy
• Tests: DTEL handler unit tests and TABL handler roundtrip tests

ABAP CDS Parser (packages/acds) — NEW PACKAGE

• New package: Chevrotain-based ABAP CDS DDL source parser
• Tokenizer, parser, AST, and visitor pattern for CDS source types
• Used by cds-to-abapgit.ts converter to parse CDS-sourced table definitions

MCP (packages/adt-mcp)

• tsconfig.json: Add project references to adt-contracts and adt-client

CLI (packages/adt-cli)

• Commands: Add check, unlock, import object commands
• Import service: Single-object import by name (search → load → format)
• Import service: Object type filter matches both full type (TABL/DS) and main type (TABL)
• Plugin loader: Support format plugins with import/export capabilities

Export Plugin (packages/adt-export)

• Roundtrip command: Export → deploy cycle with activation support
• Activate command: Bulk activation of objects in a package
• FileTree: Enhanced with directory walking and file operations for deploy

Verified Roundtrip Scenarios

Object Type	Export	Deploy	Status
INTF (Interface)	OK	OK	Fully working
CLAS (Class)	OK	OK	Fully working
PROG (Program)	OK	OK	Fully working
FUGR (Function Group)	OK	OK	Fully working
DOMA (Domain)	OK	OK	Fully working
DTEL (Data Element)	OK	OK	Fully working
TABL/DT (Table)	OK	OK	DD02V + DD03P roundtrip working
TABL/DS (Structure)	OK	OK	Uses correct /ddic/structures/ endpoint
TTYP (Table Type)	OK	OK	Fully working
DEVC (Package)	OK	N/A	Export only (metadata)

Key Bug Fixes

• Structure endpoint resolution: devc.model.ts was stripping subtypes (TABL/DS → TABL) causing structures to hit /ddic/tables/ instead of /ddic/structures/. Fixed by preserving full ADT type string.
• DD02V/DD03P field ordering: XML builder uses XSD definition order, not JS property order. Reordered XSD elements to match standard abapGit output.
• Skip-unchanged optimization: Source-based objects compare remote content before locking to avoid unnecessary lock/PUT cycles.

Remaining Work

• DD09L (technical settings) serialization for tables
• TABL_EXTRAS serialization for tables
• MSAG (message class) support
• ENHO (enhancement) support
• Additional DDIC types (SHLP, TRAN, etc.)

Test plan

• Build passes: bunx nx run-many -t build -p adk adt-plugin-abapgit adt-export adt-cli
• DTEL handler unit tests pass
• TABL handler roundtrip tests pass
• Manual roundtrip verified on BTP system for all listed object types
• Full bunx nx test suite (some pre-existing failures unrelated to this PR)

Submodules

• git_modules/abapgit-examples: Updated to include DDIC example objects (ZAGE_STRUCTURE, ZAGE_TABL, etc.)

Generated with Devin

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6498fac1-0e95-4c60-8605-7a3d388c3d82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/abapgit-roundtrip

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit d7578d3

Command	Status	Duration	Result
nx affected -t lint test build e2e-ci --verbose...	❌ Failed	17s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-03-18 07:41:42 UTC

[nx-cloud]

Nx Cloud is proposing a fix for your failed CI:

We address three ESLint errors introduced by this PR across check.ts, unlock.ts, and cds-to-abapgit.ts. Redundant : string type annotations on default-valued parameters are removed to satisfy @typescript-eslint/no-inferrable-types, and the re-thrown error in unlock.ts now passes { cause: unlockError } to satisfy the preserve-caught-error rule.

Tip

✅ We verified this fix by re-running adt-plugin-abapgit:lint.

Suggested Fix changes

diff --git a/packages/adt-cli/src/lib/commands/check.ts b/packages/adt-cli/src/lib/commands/check.ts
index 0e2577e..4d954e9 100644
--- a/packages/adt-cli/src/lib/commands/check.ts
+++ b/packages/adt-cli/src/lib/commands/check.ts
@@ -157,7 +157,7 @@ async function resolvePackageObjects(
  */
 function buildCheckObjectListXml(
   objects: Array<{ uri: string }>,
-  version: string = 'active',
+  version = 'active',
 ): string {
   const checkObjects = objects
     .map(
diff --git a/packages/adt-cli/src/lib/commands/unlock.ts b/packages/adt-cli/src/lib/commands/unlock.ts
index 8dafcb3..777ca13 100644
--- a/packages/adt-cli/src/lib/commands/unlock.ts
+++ b/packages/adt-cli/src/lib/commands/unlock.ts
@@ -102,7 +102,9 @@ async function performUnlock(
     if (msg.includes('not locked') || msg.includes('not enqueued')) {
       console.log(`ℹ️  ${objectName} is not locked`);
     } else {
-      throw new Error(`Unlock failed for ${objectName}: ${msg}`);
+      throw new Error(`Unlock failed for ${objectName}: ${msg}`, {
+        cause: unlockError,
+      });
     }
   }
 }
diff --git a/packages/adt-plugin-abapgit/src/lib/handlers/cds-to-abapgit.ts b/packages/adt-plugin-abapgit/src/lib/handlers/cds-to-abapgit.ts
index 5de3338..cc18148 100644
--- a/packages/adt-plugin-abapgit/src/lib/handlers/cds-to-abapgit.ts
+++ b/packages/adt-plugin-abapgit/src/lib/handlers/cds-to-abapgit.ts
@@ -415,7 +415,7 @@ async function buildFieldDD03P(
  */
 export async function buildDD03P(
   members: TableMember[],
-  tableName: string = '',
+  tableName = '',
   resolver?: TypeResolver,
 ): Promise<DD03PData[]> {
   const entries: DD03PData[] = [];
diff --git a/packages/adt-plugin-abapgit/tests/handlers/dtel-e2e.test.ts b/packages/adt-plugin-abapgit/tests/handlers/dtel-e2e.test.ts
index 458d390..145455a 100644
--- a/packages/adt-plugin-abapgit/tests/handlers/dtel-e2e.test.ts
+++ b/packages/adt-plugin-abapgit/tests/handlers/dtel-e2e.test.ts
@@ -13,11 +13,16 @@ import assert from 'node:assert';
 
 import { parseXml, type Schema } from '@abapify/ts-xsd';
 
-// Import the raw schema literals (these are the generated schema JS objects)
+// Import typed schemas and extract the raw schema literals via .schema
 // The dataelementWrapper imports adtcore + dataelements schemas
-import dataelementWrapperSchema from '../../../adt-schemas/src/schemas/generated/schemas/custom/dataelementWrapper.ts';
-import adtcoreSchema from '../../../adt-schemas/src/schemas/generated/schemas/sap/adtcore.ts';
-import dataelementsSchema from '../../../adt-schemas/src/schemas/generated/schemas/sap/dataelements.ts';
+import {
+  dataelementWrapper,
+  adtcore,
+  dataelements,
+} from '@abapify/adt-schemas';
+const dataelementWrapperSchema = dataelementWrapper.schema;
+const adtcoreSchema = adtcore.schema;
+const dataelementsSchema = dataelements.schema;
 
 // Import handler to trigger registration
 import '../../src/lib/handlers/objects/dtel.ts';

  

Or Apply changes locally with:

npx nx-cloud apply-locally wGVs-khrH

Apply fix locally with your editor ↗   View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

[sonarqubecloud]

Quality Gate failed

Failed conditions
8 Security Hotspots
9.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud