Cleanup and upgrade .net10.0#10
Open
adambarath wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restructures the repository under src/, adds standard Visual Studio/.NET project artifacts (solution, designer/resources/settings), and attempts to upgrade the WinForms app to a newer .NET target while updating dependencies.
Changes:
- Introduces a solution file plus WinForms designer/resources/settings files under
src/PDFDeSecure/. - Updates the project target framework and bumps the
PDFsharppackage version. - Adds repo-level
.gitignoreand a more complete.editorconfig, and updates README build instructions.
Reviewed changes
Copilot reviewed 18 out of 73 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/PDFDeSecure/PDFDeSecure.csproj |
Updates target framework and package reference; adds build/code-style properties. |
src/PDFDeSecure/Properties/PublishProfiles/FolderProfile.pubxml |
Adds a filesystem publish profile (currently pins a TFM). |
src/PDFDeSecure/Program.cs |
Keeps existing batch “auto processing” entrypoint logic; formatting/ordering changes. |
src/PDFDeSecure/PDFDeSecure.cs |
WinForms UI logic retained; designer-backed form code added to repo. |
src/PDFDeSecure/PDFDeSecure.Designer.cs |
Adds WinForms designer-generated layout and control wiring. |
src/PDFDeSecure/PDFDeSecure.resx |
Adds form resource file (icon + designer metadata). |
src/PDFDeSecure/Properties/Resources.resx |
Adds project resources resx (currently only headers). |
src/PDFDeSecure/Properties/Resources.Designer.cs |
Adds strongly-typed resource accessor (auto-generated). |
src/PDFDeSecure/Properties/Settings.settings |
Adds application settings definition file. |
src/PDFDeSecure/Properties/Settings.Designer.cs |
Adds settings wrapper class (auto-generated). |
src/PDFDeSecure/app.manifest |
Adds application manifest (UAC + compatibility). |
src/PDFDeSecure/App.config |
Adds app config (currently contains .NET Framework startup settings). |
src/PDFDeSecure.sln |
Adds a solution file pointing at the PDFDeSecure project and solution items. |
src/.editorconfig |
Adds repo style/analyzer configuration for C# and XML artifacts. |
README.md |
Updates build instructions to use the src/ layout. |
.gitignore |
Adds a comprehensive ignore list for .NET/VS build + user artifacts. |
.editorconfig |
Removes the previous minimal root editorconfig in favor of src/.editorconfig. |
Comments suppressed due to low confidence (4)
src/PDFDeSecure/Program.cs:56
- Building paths via
Output + "\\" + fi.Nameis error-prone (double slashes, missing slashes) and makes it harder to validate paths. UsePath.Combine(Output, fi.Name)(and similarly for the error log path).
src/PDFDeSecure/PDFDeSecure.csproj:5 TargetFrameworkis set tonet10.0-windows, which is not a currently supported .NET target framework moniker on released SDKs and will fail restore/build in CI. Use a released TFM (e.g.,net8.0-windows/net9.0-windows) and align publish profiles accordingly.
src/PDFDeSecure/Program.cs:59- When no PDFs are found (
aryFiempty),counter + erroris 0 and the percentage calculation divides by zero. Guard this case (e.g., show a separate message when total == 0) before computing the percentage.
src/PDFDeSecure/Program.cs:51 - File streams and
PdfDocumentinstances are manually closed/disposed inside thetryblock, but if an exception occurs after opening the stream, resources may leak (and output streams fromOpenWrite()are never disposed). Preferusingstatements (ortry/finally) forfi.OpenRead(),new FileInfo(...).OpenWrite(), and thePdfDocumentinstances.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
58da8b6 to
3039a7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.