🛡️ Sentinel: Upgrade SSRF protection to block non-global and multicast IPs by google-labs-jules[bot] · Pull Request #115 · abhimehro/ctrld-sync

google-labs-jules · 2026-01-19T11:02:27Z

🛡️ Sentinel Security Update

🚨 Vulnerability Fix

Upgraded Server-Side Request Forgery (SSRF) protection in validate_folder_url.

The previous implementation used ip.is_private which allows several non-public IP ranges:

Carrier-Grade NAT (CGNAT): 100.64.0.0/10
Link-Local: 169.254.0.0/16 (in some contexts)
Reserved: 240.0.0.0/4, etc.
Multicast: 224.0.0.0/4

🔧 The Fix

Switched to using ip.is_global (introduced in Python 3.4), which correctly identifies addresses allocated for public networks.

if not ip.is_global or ip.is_multicast:
    return False

Note: We explicitly block is_multicast because is_global considers multicast addresses as global.

✅ Verification

Added new tests in tests/test_ssrf_enhanced.py that specifically target these previously allowed ranges. All tests passed.

📦 Dependency Note

Updated .python-version to 3.13 to align with pyproject.toml's requires-python = ">=3.13".

PR created automatically by Jules for task 12310260580531266516 started by @abhimehro

…t IPs Fixes a gap in SSRF protection where Carrier-Grade NAT (100.64.0.0/10), Link-Local, and Reserved IP ranges were allowed because `is_private` does not cover them. Changes: - Replaced `ip.is_private or ip.is_loopback` with `not ip.is_global or ip.is_multicast`. - Added `tests/test_ssrf_enhanced.py` to verify blocking of CGNAT and Multicast addresses. - Updated `.python-version` to 3.13 to match `pyproject.toml` requirements and support modern `ipaddress` features.

google-labs-jules · 2026-01-19T11:02:28Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

trunk-io · 2026-01-19T11:02:32Z

😎 Merged manually by Abhi Mehrotra (@abhimehro) - details.

tests/test_ssrf_enhanced.py

.jules/sentinel.md

 2. Check all returned IPs against private and loopback ranges.
 3. Fail closed (block the URL) if resolution fails or returns any private IP.
+
+## 2026-03-22 - [SSRF Protection Gaps in Python ipaddress]


.jules/sentinel.md

 2. Check all returned IPs against private and loopback ranges.
 3. Fail closed (block the URL) if resolution fails or returns any private IP.
+
+## 2026-03-22 - [SSRF Protection Gaps in Python ipaddress]


tests/test_ssrf_enhanced.py

+        with patch('socket.getaddrinfo') as mock_getaddrinfo:
+            # Simulate resolving to 0.0.0.0
+            mock_getaddrinfo.return_value = [
+                (socket.AF_INET, socket.SOCK_STREAM, 6, '', ('0.0.0.0', 443))


main.py

-            if ip.is_private or ip.is_loopback:
-                log.warning(f"Skipping unsafe URL (private IP): {sanitize_for_log(url)}")
+            if not ip.is_global or ip.is_multicast:
+                log.warning(f"Skipping unsafe URL (non-global/multicast IP): {sanitize_for_log(url)}")


main.py

-                    if ip.is_private or ip.is_loopback:
-                        log.warning(f"Skipping unsafe URL (domain {hostname} resolves to private IP {ip}): {sanitize_for_log(url)}")
+                    if not ip.is_global or ip.is_multicast:
+                        log.warning(f"Skipping unsafe URL (domain {hostname} resolves to non-global/multicast IP {ip}): {sanitize_for_log(url)}")


tests/test_ssrf_enhanced.py

@@ -0,0 +1,58 @@
+


tests/test_ssrf_enhanced.py

+# Add root to path to import main
+sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+import main


tests/test_ssrf_enhanced.py

+
+import main
+
+class TestSSRFEnhanced(unittest.TestCase):


main.py

-            if ip.is_private or ip.is_loopback:
-                log.warning(f"Skipping unsafe URL (private IP): {sanitize_for_log(url)}")
+            if not ip.is_global or ip.is_multicast:
+                log.warning(f"Skipping unsafe URL (non-global/multicast IP): {sanitize_for_log(url)}")


main.py

-                    if ip.is_private or ip.is_loopback:
-                        log.warning(f"Skipping unsafe URL (domain {hostname} resolves to private IP {ip}): {sanitize_for_log(url)}")
+                    if not ip.is_global or ip.is_multicast:
+                        log.warning(f"Skipping unsafe URL (domain {hostname} resolves to non-global/multicast IP {ip}): {sanitize_for_log(url)}")


tests/test_ssrf_enhanced.py

+# Add root to path to import main
+sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+import main


tests/test_ssrf_enhanced.py

+            result = main.validate_folder_url(url)
+            self.assertFalse(result, "Should block domain resolving to 0.0.0.0")
+
+if __name__ == '__main__':


main.py

-            if ip.is_private or ip.is_loopback:
-                log.warning(f"Skipping unsafe URL (private IP): {sanitize_for_log(url)}")
+            if not ip.is_global or ip.is_multicast:
+                log.warning(f"Skipping unsafe URL (non-global/multicast IP): {sanitize_for_log(url)}")


main.py

-                    if ip.is_private or ip.is_loopback:
-                        log.warning(f"Skipping unsafe URL (domain {hostname} resolves to private IP {ip}): {sanitize_for_log(url)}")
+                    if not ip.is_global or ip.is_multicast:
+                        log.warning(f"Skipping unsafe URL (domain {hostname} resolves to non-global/multicast IP {ip}): {sanitize_for_log(url)}")


tests/test_ssrf_enhanced.py

@@ -0,0 +1,58 @@
+


tests/test_ssrf_enhanced.py

+# Add root to path to import main
+sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+import main


tests/test_ssrf_enhanced.py

+
+import main
+
+class TestSSRFEnhanced(unittest.TestCase):


main.py

-            if ip.is_private or ip.is_loopback:
-                log.warning(f"Skipping unsafe URL (private IP): {sanitize_for_log(url)}")
+            if not ip.is_global or ip.is_multicast:
+                log.warning(f"Skipping unsafe URL (non-global/multicast IP): {sanitize_for_log(url)}")


main.py

-                    if ip.is_private or ip.is_loopback:
-                        log.warning(f"Skipping unsafe URL (domain {hostname} resolves to private IP {ip}): {sanitize_for_log(url)}")
+                    if not ip.is_global or ip.is_multicast:
+                        log.warning(f"Skipping unsafe URL (domain {hostname} resolves to non-global/multicast IP {ip}): {sanitize_for_log(url)}")


github-actions bot added the python label Jan 19, 2026

github-advanced-security bot found potential problems Jan 19, 2026

View reviewed changes

tests/test_ssrf_enhanced.py Dismissed Show dismissed Hide dismissed

github-advanced-security bot found potential problems Jan 19, 2026

View reviewed changes

abhimehro marked this pull request as ready for review January 19, 2026 18:44

Copilot AI review requested due to automatic review settings January 19, 2026 18:44

Copilot started reviewing on behalf of abhimehro January 19, 2026 18:45 View session

abhimehro merged commit 7b9d274 into main Jan 19, 2026
23 of 24 checks passed

abhimehro deleted the sentinel-ssrf-upgrade-12310260580531266516 branch January 19, 2026 19:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🛡️ Sentinel: Upgrade SSRF protection to block non-global and multicast IPs#115

🛡️ Sentinel: Upgrade SSRF protection to block non-global and multicast IPs#115
abhimehro merged 1 commit intomainfrom
sentinel-ssrf-upgrade-12310260580531266516

google-labs-jules bot commented Jan 19, 2026

Uh oh!

google-labs-jules bot commented Jan 19, 2026

Uh oh!

trunk-io bot commented Jan 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check notice

Check notice

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

google-labs-jules bot commented Jan 19, 2026

🛡️ Sentinel Security Update

🚨 Vulnerability Fix

🔧 The Fix

✅ Verification

📦 Dependency Note

Uh oh!

google-labs-jules bot commented Jan 19, 2026

Uh oh!

trunk-io bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check notice

Check notice

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

trunk-io bot commented Jan 19, 2026 •

edited

Loading