🛡️ Sentinel: [MEDIUM] Fix log injection vulnerabilities by google-labs-jules[bot] · Pull Request #122 · abhimehro/ctrld-sync

google-labs-jules · 2026-01-22T10:58:57Z

🚨 Severity: MEDIUM (Terminal Log Injection)
💡 Vulnerability: User-controlled inputs (folder names from JSON, error messages) were logged directly using f-strings. This allowed malicious JSON sources to inject ANSI escape sequences, potentially corrupting terminal output or spoofing logs.
🎯 Impact: Terminal hijacking or log spoofing.
🔧 Fix: Applied sanitize_for_log (which uses repr() to escape control characters) to the missing call sites. Added regression test.
✅ Verification: Ran uv run pytest tests/test_log_sanitization.py. All tests passed.

PR created automatically by Jules for task 768802791969432720 started by @abhimehro

Fixed missing sanitization in logging calls where user-controlled input (folder names, errors) was interpolated directly. This prevents Terminal Escape Sequence Injection. Added regression test `tests/test_log_sanitization.py`. Updated `sanitize_for_log` documentation.

google-labs-jules · 2026-01-22T10:58:58Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

trunk-io · 2026-01-22T10:59:01Z

Merging to main in this repository is managed by Trunk.

To merge this pull request, check the box to the left or comment /trunk merge below.

.jules/sentinel.md

 **Prevention:**
 1. Always use `if not ip.is_global or ip.is_multicast:` for strict SSRF filtering, rather than manual blacklists of private ranges.
+
+## 2026-05-18 - [Log Injection via Unsanitized Input]


.jules/sentinel.md

 **Prevention:**
 1. Always use `if not ip.is_global or ip.is_multicast:` for strict SSRF filtering, rather than manual blacklists of private ranges.
+
+## 2026-05-18 - [Log Injection via Unsanitized Input]


main.py

            if attempt < MAX_RETRIES:
                wait_time = FOLDER_CREATION_DELAY * (attempt + 1)
-                log.info(f"Folder '{name}' not found yet. Retrying in {wait_time}s...")
+                log.info(f"Folder '{sanitize_for_log(name)}' not found yet. Retrying in {wait_time}s...")


main.py

                            success_count += 1
                    except Exception as e:
-                        log.error(f"Failed to process folder '{folder_name}': {e}")
+                        log.error(f"Failed to process folder '{sanitize_for_log(folder_name)}': {sanitize_for_log(e)}")


tests/test_log_sanitization.py

@@ -0,0 +1,88 @@
+import unittest
+from unittest.mock import MagicMock, patch
+import sys


tests/test_log_sanitization.py

+import unittest
+from unittest.mock import MagicMock, patch
+import sys
+import os


tests/test_log_sanitization.py

+    @patch('main.time.sleep')
+    @patch('main._api_post')
+    @patch('main._api_get')
+    def test_create_folder_logs_unsafe_name(self, mock_get, mock_post, mock_sleep, mock_log):


tests/test_log_sanitization.py

+            # But wait, if the source is f"Folder '{name}'...", logging receives the formatted string.
+            log_msg = args[0]
+            if unsafe_name in log_msg:
+                 found_raw = True


tests/test_log_sanitization.py

+            # But wait, if the source is f"Folder '{name}'...", logging receives the formatted string.
+            log_msg = args[0]
+            if unsafe_name in log_msg:
+                 found_raw = True


tests/test_log_sanitization.py

+            if unsafe_name in log_msg:
+                 found_raw = True
+            if sanitized_name in log_msg:
+                 found_sanitized = True


tests/test_log_sanitization.py

+            if unsafe_name in log_msg:
+                 found_raw = True
+            if sanitized_name in log_msg:
+                 found_sanitized = True


tests/test_log_sanitization.py

+        self.assertTrue(found_sanitized, "Should find sanitized name in logs")
+        self.assertFalse(found_raw, "Should not find raw name in logs")
+
+if __name__ == '__main__':


main.py

            if attempt < MAX_RETRIES:
                wait_time = FOLDER_CREATION_DELAY * (attempt + 1)
-                log.info(f"Folder '{name}' not found yet. Retrying in {wait_time}s...")
+                log.info(f"Folder '{sanitize_for_log(name)}' not found yet. Retrying in {wait_time}s...")


main.py

                            success_count += 1
                    except Exception as e:
-                        log.error(f"Failed to process folder '{folder_name}': {e}")
+                        log.error(f"Failed to process folder '{sanitize_for_log(folder_name)}': {sanitize_for_log(e)}")


tests/test_log_sanitization.py

@@ -0,0 +1,88 @@
+import unittest


tests/test_log_sanitization.py

+import os
+import main
+
+class TestLogSanitization(unittest.TestCase):


tests/test_log_sanitization.py

+            args = call[0]
+            # Since it is an f-string in the source, we can't easily check format args.
+            # We have to check the string content.
+            # But wait, if the source is f"Folder '{name}'...", logging receives the formatted string.


tests/test_log_sanitization.py

+import unittest
+from unittest.mock import MagicMock, patch
+import sys
+import os


tests/test_log_sanitization.py

+    @patch('main.time.sleep')
+    @patch('main._api_post')
+    @patch('main._api_get')
+    def test_create_folder_logs_unsafe_name(self, mock_get, mock_post, mock_sleep, mock_log):


tests/test_log_sanitization.py

+
+        # Check logs
+        # We look for the specific log message: "Folder '{name}' not found yet..."
+        found_unsafe_log = False


tests/test_log_sanitization.py

+            # But wait, if the source is f"Folder '{name}'...", logging receives the formatted string.
+            log_msg = args[0]
+            if unsafe_name in log_msg:
+                 found_raw = True


tests/test_log_sanitization.py

+            if unsafe_name in log_msg:
+                 found_raw = True
+            if sanitized_name in log_msg:
+                 found_sanitized = True


main.py

            if attempt < MAX_RETRIES:
                wait_time = FOLDER_CREATION_DELAY * (attempt + 1)
-                log.info(f"Folder '{name}' not found yet. Retrying in {wait_time}s...")
+                log.info(f"Folder '{sanitize_for_log(name)}' not found yet. Retrying in {wait_time}s...")


main.py

                            success_count += 1
                    except Exception as e:
-                        log.error(f"Failed to process folder '{folder_name}': {e}")
+                        log.error(f"Failed to process folder '{sanitize_for_log(folder_name)}': {sanitize_for_log(e)}")


tests/test_log_sanitization.py

@@ -0,0 +1,88 @@
+import unittest


tests/test_log_sanitization.py

+import os
+import main
+
+class TestLogSanitization(unittest.TestCase):


tests/test_log_sanitization.py

+    @patch('main.time.sleep')
+    @patch('main._api_post')
+    @patch('main._api_get')
+    def test_create_folder_logs_unsafe_name(self, mock_get, mock_post, mock_sleep, mock_log):


tests/test_log_sanitization.py

+import unittest
+from unittest.mock import MagicMock, patch
+import sys
+import os


tests/test_log_sanitization.py

+    @patch('main.time.sleep')
+    @patch('main._api_post')
+    @patch('main._api_get')
+    def test_create_folder_logs_unsafe_name(self, mock_get, mock_post, mock_sleep, mock_log):


tests/test_log_sanitization.py

+
+        # Check logs
+        # We look for the specific log message: "Folder '{name}' not found yet..."
+        found_unsafe_log = False


tests/test_log_sanitization.py

+            # But wait, if the source is f"Folder '{name}'...", logging receives the formatted string.
+            log_msg = args[0]
+            if unsafe_name in log_msg:
+                 found_raw = True


tests/test_log_sanitization.py

+            if unsafe_name in log_msg:
+                 found_raw = True
+            if sanitized_name in log_msg:
+                 found_sanitized = True


Copilot

Pull request overview

This PR fixes log injection vulnerabilities where user-controlled inputs (folder names from JSON and error messages) were logged without sanitization, potentially allowing terminal escape sequence injection.

Changes:

Enhanced sanitize_for_log function documentation to clarify control character escaping
Applied sanitize_for_log to folder names and error messages in two critical log call sites
Added comprehensive regression tests to verify the fix

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
main.py	Added sanitization to folder name logging in `create_folder` and error logging in `sync_profile`
tests/test_log_sanitization.py	Added new test suite with ANSI escape sequence injection tests
.jules/sentinel.md	Documented the vulnerability and prevention strategy

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/test_log_sanitization.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions bot added the python label Jan 22, 2026

github-advanced-security bot found potential problems Jan 22, 2026

View reviewed changes

abhimehro marked this pull request as ready for review January 22, 2026 11:07

Copilot AI review requested due to automatic review settings January 22, 2026 11:07

abhimehro assigned Copilot and abhimehro Jan 22, 2026

Copilot started reviewing on behalf of abhimehro January 22, 2026 11:07 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

tests/test_log_sanitization.py Outdated Show resolved Hide resolved

tests/test_log_sanitization.py Outdated Show resolved Hide resolved

tests/test_log_sanitization.py Outdated Show resolved Hide resolved

tests/test_log_sanitization.py Outdated Show resolved Hide resolved

abhimehro and others added 4 commits January 22, 2026 05:35

Update test_log_sanitization.py

0f687d3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test_log_sanitization.py

53f67b0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test_log_sanitization.py

6f77de7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test_log_sanitization.py

3d951c2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Jan 22, 2026

[WIP] Resolve merge conflicts in pull request #124

Merged

10 tasks

abhimehro merged commit 3d951c2 into main Jan 27, 2026
8 checks passed

abhimehro deleted the sentinel/fix-log-injection-768802791969432720 branch January 27, 2026 12:16

Conversation

google-labs-jules bot commented Jan 22, 2026

Uh oh!

google-labs-jules bot commented Jan 22, 2026

Uh oh!

trunk-io bot commented Jan 22, 2026

Uh oh!

Check notice

Check notice

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check notice

Check notice

Check notice

Check notice

Check notice

Check warning

Check warning

Check warning

Check warning

Check warning

Check notice

Check notice

Check notice

Check notice

Check notice

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants